-
Couldn't load subscription status.
- Fork 83
feat: add model description to dropdown #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e827f35 to
87c35fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 61.23% 61.22% -0.02%
==========================================
Files 261 261
Lines 58281 58291 +10
Branches 3579 3579
==========================================
Hits 35689 35689
- Misses 22524 22534 +10
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
59f8e9d to
57cef4a
Compare
57cef4a to
1f70c2a
Compare
1f70c2a to
bc1ca28
Compare
| [BedrockModel.CLAUDE_SONNET_4_20250514_V1_0]: { label: 'Claude Sonnet 4' }, | ||
| [BedrockModel.CLAUDE_SONNET_4_20250514_V1_0]: { | ||
| label: 'Claude Sonnet 4', | ||
| description: 'Hybrid reasoning and coding for regular use', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this change on the backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most probably it wont change but this is valid until for initial listAvailableModel API call so it should be fine.
|
|
||
| export const FALLBACK_MODEL_RECORD: Record<BedrockModel, ModelDetails> = { | ||
| [BedrockModel.CLAUDE_3_7_SONNET_20250219_V1_0]: { label: 'Claude 3.7 Sonnet' }, | ||
| [BedrockModel.CLAUDE_SONNET_4_20250514_V1_0]: { label: 'Claude Sonnet 4' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
callout for future: probably worth adding a comment: since we are also removing 3.7, we have to be careful not to remove sonnet 4 because if for some reason call to the backend fails, there will be no fallback left to show in the UI
Problem
The backend now provides a model description, which we would also like to display as a tooltip when hovering over the model name
Solution
Add model description as a tooltip when hovering over model:
Testing in all 4 IDEs
VSC.mov
JB.mov
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.