fix: Enable Test Flag For AmazonQ UI Testing #2046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the Mynah-UI elements do not show
data-testidat the production level of Amazon Q. This makes UI Tests very flakey because we have to rely on CSS Selectors to grab Mynah-UI elements, and these CSS Selectors can be shared across multiple different elements.Solution
In
mynahUI.tswe settest:truesodata-testidwill show at production level. Now instead of using CSS Selectors, test writers can grab thedata-testidThis is the code in Mynah-UI that turns on test-ids when test config is set to
truehttps://github.com/aws/mynah-ui/blob/main/src/helper/dom.ts#L264
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.