Skip to content

Conversation

@yzhangok
Copy link
Contributor

Problem

Invalid Image notification shown even all dropped images are valid.

Screenshot 2025-07-29 at 3 56 37 PM

Solution

Add conditional check to only show the notification when there are more than one errors

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yzhangok yzhangok requested a review from a team as a code owner July 29, 2025 22:58
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.16%. Comparing base (68adf18) to head (b3fcac6).

Files with missing lines Patch % Lines
chat-client/src/client/mynahUi.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2007      +/-   ##
==========================================
+ Coverage   61.15%   61.16%   +0.01%     
==========================================
  Files         239      239              
  Lines       52115    52117       +2     
  Branches     3127     3130       +3     
==========================================
+ Hits        31869    31879      +10     
+ Misses      20187    20179       -8     
  Partials       59       59              
Flag Coverage Δ
unittests 61.16% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yzhangok yzhangok merged commit ceed762 into aws:main Jul 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants