fix(jsii-pacmak): CS0108 <static property> hides inherited member #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# requires that we explicitly declare when static members are changed in subclasses. In #2373 we added the ability to change the definition of static functions in this way, but we missed doing the same for static properties. Give them the same treatment.
rix0rrr
changed the title
Since the removal of a class in Python 3.12, we need a more modern version of `setuptools` to work on newer Python versions. This gets rid of the error: ``` AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'? ```
iliapolo
approved these changes
May 7, 2025
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# requires that we explicitly declare when static members are changed in subclasses. In #2373 we added the ability to change the definition of static functions and static read/write properties in this way, but we missed doing the same for static
constproperties.Give them the same treatment.
(PR includes #4827)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.