Skip to content

Add encryption option to Neptune CloudFormation template #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd

- New notebooks showing Telco examples leveraging GNN and LLM ([Link to PR](https://github.com/aws/graph-notebook/pull/587))
- Path: 02-Neptune-ML > 03-Sample-Applications > 04-Telco-Networks
- Added KMS encryption support to NeptuneDB Notebook CloudFormation template (https://github.com/aws/graph-notebook/pull/590)

## Release 4.2.0 (April 4, 2024)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Parameters:
Type: List<AWS::EC2::SecurityGroup::Id>

NeptuneClusterSubnetId:
Description: The ID of the subnet in a VPC to which you would like to have a connectivity from your ML compute instance.
Description: The ID of the subnet in a VPC to which you would like to have connectivity from your ML compute instance.
Type: AWS::EC2::Subnet::Id

SageMakerNotebookRoleArn:
Expand All @@ -91,6 +91,11 @@ Parameters:
Description: The name of the Neptune notebook.
Type: String

EncryptionKey:
Description: 'OPTIONAL: The ARN of a KMS key to encrypt your notebook data with.'
Type: String
Default: ''

Conditions:
UseSageMakerNotebookAutoRole:
Fn::Equals:
Expand Down Expand Up @@ -127,6 +132,8 @@ Resources:
Value: !Select [ 0, !Split [ ".", !Ref NeptuneClusterEndpoint ] ]
- Key: aws-neptune-resource-id
Value: !Ref NeptuneClusterResourceId
KmsKeyId:
Ref: EncryptionKey

NeptuneNotebookInstanceLifecycleConfig:
Type: AWS::SageMaker::NotebookInstanceLifecycleConfig
Expand Down