Skip to content

Adds notebooks for Telco-Network application with GNN and LLM. #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

ImenGBY
Copy link
Contributor

@ImenGBY ImenGBY commented Apr 9, 2024

Description of changes:
Adds notebooks for the Telco-Network blog with GNN and GenAI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krlawrence
Copy link
Contributor

I kicked off the tests. Please can you take a look at the Unit test results for Transform2Neptune.py @ImenGBY ?

@krlawrence krlawrence self-requested a review April 19, 2024 16:42
@krlawrence
Copy link
Contributor

Please also include an updated ChangeLog.md as part of the PR, you can model the wording along the lines of the update recently made for the SBOM notebooks. Please add the text beneath "Upcoming".

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the updated ChangeLog is available now that the test failures are fixed everything else LGTM.

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes. Looks good to go from my perspective.

@krlawrence krlawrence merged commit 44b15cb into aws:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

3 participants