Skip to content

updates to graph_notebook_config for Amazon Neptune Proxy Connection #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

cubeddu
Copy link
Contributor

@cubeddu cubeddu commented Jun 19, 2023

Issue #399

Description of changes:

I have enhanced the documentation for the graph_notebook_config table to include all possible properties and clarify when the proxy_host and proxy_port are exclusively utilized for Amazon Neptune, plus fixed all markdown warnings in README.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cubeddu cubeddu marked this pull request as ready for review June 20, 2023 00:01
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, couple changes requested in config docs.

@cubeddu
Copy link
Contributor Author

cubeddu commented Jul 10, 2023

Looks good overall, couple changes requested in config docs.

Changes made to reflect the latest request.

@cubeddu cubeddu requested a review from michaelnchin July 10, 2023 23:25
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cubeddu !

@xiazcy
Copy link

xiazcy commented Aug 1, 2023

Quick followup, @michaelnchin do we still plan to merge this PR? Thanks!

@michaelnchin michaelnchin merged commit 1068ac5 into aws:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants