Revert "Implement PEP3134 to discover underlying problems with python 3 (#355)" #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolabadeer
approved these changes
Dec 19, 2022
|
Before closing this PR, I was curious if there is another workaround to fix the issues with python3 mentioned in the previous PR #355? I think it would be beneficial to implement that, unless it will always result in the X-Ray portion of the stack trace to be omitted |
PR #355 is not a workaround or solution. I don't know what caused sentry being hidden from the stacktrace. I don't have a way to reproduce this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #370
Description of changes: This reverts commit 4660169 (PR #355)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.