Refactor PluginOption#doc_default #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be already merged in. Closing! |
|
@mullermp Checking in to see if you caught my previous comment. I understand if this PR is not desired, but I wanted to make sure. |
|
@jonathanhefner Sorry on the delayed response. I must have mixed this up with the other PR. (and no sorry I missed your comment.. my bad.. I try my best) |
|
@mullermp No worries! 😄 And thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this method when working on eea7333. It took me a moment to understand its behavior, so I thought it would be nice to clarify the code.
(My apologies if cosmetic changes are frowned upon!)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.