Remove deprecated credential methods from credential providers (#2132)

Author: mullermp

gems/aws-sdk-core/CHANGELOG.md

@@ -1,6 +1,8 @@
 Unreleased Changes
 ------------------
 
+* Feature - Remove deprecated `access_key_id`, `secret_access_key`, and `session_token` methods in credential providers.
+
 3.74.0 (2019-11-05)
 ------------------
 

gems/aws-sdk-core/lib/aws-sdk-core/credential_provider.rb

@@ -1,10 +1,6 @@
-require_relative 'deprecations'
-
 module Aws
   module CredentialProvider
 
-    extend Deprecations
-
     # @return [Credentials]
     attr_reader :credentials
 
@@ -13,29 +9,5 @@ def set?
       !!credentials && credentials.set?
     end
 
-    # @deprecated This method is subject to errors from a race condition when
-    # called against refreshable credential objects. This will be removed.
-    # @see #credentials
-    def access_key_id
-      credentials ? credentials.access_key_id : nil
-    end
-    deprecated(:access_key_id, use: '#credentials', version: '3.75')
-
-    # @deprecated This method is subject to errors from a race condition when
-    # called against refreshable credential objects. This will be removed.
-    # @see #credentials
-    def secret_access_key
-      credentials ? credentials.secret_access_key : nil
-    end
-    deprecated(:secret_access_key, use: '#credentials', version: '3.75')
-
-    # @deprecated This method is subject to errors from a race condition when
-    # called against refreshable credential objects. This will be removed.
-    # @see #credentials
-    def session_token
-      credentials ? credentials.session_token : nil
-    end
-    deprecated(:session_token, use: '#credentials', version: '3.75')
-
   end
 end

gems/aws-sdk-core/spec/aws/assume_role_credentials_spec.rb

@@ -100,22 +100,5 @@ module Aws
       c.credentials
     end
 
-    it 'generates deprecation warnings for credential accessors' do
-      c = AssumeRoleCredentials.new(
-        role_arn: 'arn',
-        role_session_name: 'session')
-
-      expect(c).to receive(:warn).exactly(3).times
-
-      c.access_key_id
-      c.secret_access_key
-      c.session_token
-
-      # warnings are not duplicated
-      c.access_key_id
-      c.secret_access_key
-      c.session_token
-    end
-
   end
 end