Generate PutBucketEncryption, GetBucketEncryption, GetBucketAccelerate

[peterrsongg]

Description

In this PR I generate PutBucketEncryption, GetBucketEncryption, and GetBucketAccelerate. As discussed, phase 1 will include updates to our rest-xml tt files too since they aren't used for many services and will now be used for the most used service. As such, I have refactored where I thought necessary to reduce code duplication by moving things into functions that can be reusable. I've added comments in the PR as to why I did so.

Motivation and Context

Testing

Output from AssemblyComparer ( All are internal and the ones that aren't I checked and there were no backwards incompatibilities)

C:\Dev\Repos\AwsSdkDotNetBuildUtilities\AssemblyComparer\AssemblyComparer\bin\Debug\net8.0 [mainline ≡]> ./AssemblyComparer.exe assembly-comparer --old-assembly "C:\AssemblyComparisons\AWSSDK.S3.Old.dll" --new-assembly "C:\AssemblyComparisons\AWSSDK.S3.New.dll"
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.Internal.MarshallTransformations.PutBucketEncryptionRequestMarshaller/ParameterNameChanged: Parameter name changed for method Amazon.Runtime.Internal.IRequest Marshall(Amazon.S3.Model.PutBucketEncryptionRequest) in Amazon.S3.Model.Internal.MarshallTransformations.PutBucketEncryptionRequestMarshaller from putBucketEncryptionRequest to publicRequest
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.AmazonS3Client/MethodReturnTypeChanged: Return type changed for method System.Threading.Tasks.Task<Amazon.S3.Model.PutBucketEncryptionResponse> PutBucketEncryptionAsync(Amazon.S3.Model.PutBucketEncryptionRequest, System.Threading.CancellationToken) in Amazon.S3.AmazonS3Client from System.Threading.Tasks.Task [System.Runtime 8.0.0.0]<Amazon.S3.PutBucketEncryptionResponse> to System.Threading.Tasks.Task [System.Runtime 8.0.0.0]<Amazon.S3.Model.PutBucketEncryptionResponse>
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.PutBucketEncryptionResponse/TypeRemoved: Missing type Amazon.S3.PutBucketEncryptionResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.Internal.MarshallTransformations.PutBucketEncryptionResponseUnmarshaller/MethodAdded: New method Amazon.Runtime.AmazonServiceException UnmarshallException(Amazon.Runtime.Internal.Transform.XmlUnmarshallerContext, System.Exception, System.Net.HttpStatusCode) in Amazon.S3.Model.Internal.MarshallTransformations.PutBucketEncryptionResponseUnmarshaller
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.Internal.MarshallTransformations.GetBucketEncryptionRequestMarshaller/ParameterNameChanged: Parameter name changed for method Amazon.Runtime.Internal.IRequest Marshall(Amazon.S3.Model.GetBucketEncryptionRequest) in Amazon.S3.Model.Internal.MarshallTransformations.GetBucketEncryptionRequestMarshaller from getEncryptionRequest to publicRequest
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.IAmazonS3/MethodReturnTypeChanged: Return type changed for method System.Threading.Tasks.Task<Amazon.S3.Model.PutBucketEncryptionResponse> PutBucketEncryptionAsync(Amazon.S3.Model.PutBucketEncryptionRequest, System.Threading.CancellationToken) in Amazon.S3.IAmazonS3 from System.Threading.Tasks.Task [System.Runtime 8.0.0.0]<Amazon.S3.PutBucketEncryptionResponse> to System.Threading.Tasks.Task [System.Runtime 8.0.0.0]<Amazon.S3.Model.PutBucketEncryptionResponse>
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.Internal.MarshallTransformations.GetBucketEncryptionResponseUnmarshaller/MethodAdded: New method Amazon.Runtime.AmazonServiceException UnmarshallException(Amazon.Runtime.Internal.Transform.XmlUnmarshallerContext, System.Exception, System.Net.HttpStatusCode) in Amazon.S3.Model.Internal.MarshallTransformations.GetBucketEncryptionResponseUnmarshaller
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.Internal.MarshallTransformations.GetBucketAccelerateConfigurationRequestMarshaller/ParameterNameChanged: Parameter name changed for method Amazon.Runtime.Internal.IRequest Marshall(Amazon.S3.Model.GetBucketAccelerateConfigurationRequest) in Amazon.S3.Model.Internal.MarshallTransformations.GetBucketAccelerateConfigurationRequestMarshaller from getBucketAccelerateRequest to publicRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.PutBucketEncryptionResponse/TypeAdded: New type Amazon.S3.Model.PutBucketEncryptionResponse
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.Internal.MarshallTransformations.GetBucketAccelerateConfigurationResponseUnmarshaller/MethodAdded: New method Amazon.Runtime.AmazonServiceException UnmarshallException(Amazon.Runtime.Internal.Transform.XmlUnmarshallerContext, System.Exception, System.Net.HttpStatusCode) in Amazon.S3.Model.Internal.MarshallTransformations.GetBucketAccelerateConfigurationResponseUnmarshaller
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.Internal.MarshallTransformations.ServerSideEncryptionConfigurationUnmarshaller/TypeAdded: New type Amazon.S3.Model.Internal.MarshallTransformations.ServerSideEncryptionConfigurationUnmarshaller

Build id: 9efcf94b-4022-4e5f-a497-e8861471e561 SUCCEEDED
For PutBucketEncryption

    var request = new PutBucketEncryptionRequest
    {
        BucketName = "petesong-east-1-bucket",
        ServerSideEncryptionConfiguration = new ServerSideEncryptionConfiguration
        {
            ServerSideEncryptionRules = new List<ServerSideEncryptionRule> 
            {
                new ServerSideEncryptionRule
                {
                    ServerSideEncryptionByDefault = new ServerSideEncryptionByDefault
                    {
                        SSEAlgorithm = ServerSideEncryptionMethod.AWSKMS, // or AES256
                        KMSMasterKeyID = "e90ac20e-d5dc-47c3-aa0d-bebd6805521f"
                    },
                    BucketKeyEnabled = true // Enables bucket key for cost optimization (only for KMS)
                }
            }
        },
        ExpectedBucketOwner = "404186920727", // Optional: the expected AWS account ID of the bucket owner
        ChecksumAlgorithm = ChecksumAlgorithm.SHA256 // Optional: supported values are SHA256, SHA1, CRC32, CRC32C
    };

    try
    {
        var response = await s3Client.PutBucketEncryptionAsync(request);
        Console.WriteLine($"Encryption configuration set for bucket: petesong-east-1-bucket");
    }
    catch (AmazonS3Exception ex)
    {
        Console.WriteLine($"Error setting encryption: {ex.Message}");
    }

validated that the request is sent correctly
What we are sending:

<ServerSideEncryptionConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <Rule>
        <BucketKeyEnabled>true</BucketKeyEnabled>
        <ApplyServerSideEncryptionByDefault>
            <KMSMasterKeyID>******</KMSMasterKeyID>
            <SSEAlgorithm>aws:kms</SSEAlgorithm>
        </ApplyServerSideEncryptionByDefault>
    </Rule>
</ServerSideEncryptionConfiguration>

From the docs

<ServerSideEncryptionConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
   <Rule>
      <ApplyServerSideEncryptionByDefault>
         <KMSMasterKeyID>string</KMSMasterKeyID>
         <SSEAlgorithm>string</SSEAlgorithm>
      </ApplyServerSideEncryptionByDefault>
      <BucketKeyEnabled>boolean</BucketKeyEnabled>
   </Rule>
   ...
</ServerSideEncryptionConfiguration>

For GetBucketEncryptionRequest

    var getBucketEncryptionRequest = new GetBucketEncryptionRequest
    {
        BucketName = "<by_bucket>",
        ExpectedBucketOwner = <my_account>
    };
        var getBucketEncryptionResponse = await s3Client.GetBucketEncryptionAsync(getBucketEncryptionRequest).ConfigureAwait(false);
        var sseConfiguration = getBucketEncryptionResponse.ServerSideEncryptionConfiguration;
        foreach (var rule in sseConfiguration.ServerSideEncryptionRules)
        {
            Console.WriteLine(rule.BucketKeyEnabled);
            Console.WriteLine(rule.ServerSideEncryptionByDefault.KMSMasterKeyID);
            Console.WriteLine(rule.ServerSideEncryptionByDefault.SSEAlgorithm);
        }

correctly printed out the results.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[normj]

Approved with a minor nit

[normj]

typo gauranteed -> guaranteed