Skip to content

Added comments in migration tool for all remaining S3 method #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 22, 2025

Conversation

Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Apr 17, 2025

Motivation and Context

This PR added support for all remaining method s3 clients for migration tool

Modifications

Added coverage in migration tool for

shutdown()
SetObjectTaggingRequest

Added comments for

setBucketLoggingConfiguration
setRequestPaymentConfiguration
setBucketLifecycleConfiguration
setBucketTaggingConfiguration
SetBucketVersioningConfigurationRequest

Testing

Tested in local sample packages

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner April 17, 2025 22:39
@Fred1155 Fred1155 requested a review from L-Applin April 21, 2025 20:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Fred1155 Fred1155 added this pull request to the merge queue Apr 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2025
@Fred1155 Fred1155 added this pull request to the merge queue Apr 22, 2025
Merged via the queue into master with commit a3ab730 Apr 22, 2025
22 of 23 checks passed
@Fred1155 Fred1155 deleted the bole/migration_tool_s3_left_methods branch April 22, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants