Fix NPE in netty client

[zoewangg]

Motivation and Context

Fix NPE in netty client where a future got cancelled before the execution id was attached to the channel

Modifications

Add null check in FutureCancelHandler to handle the edge case

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

I think this change is fine, but it only fixes a symptom IMO. We shouldn't be throwing the FutureCancelledException without the channel having an executionId.

[zoewangg]

Yeah, good point. Will update.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

86.7% Coverage
0.0% Duplication