Add an Optional getter for the contentLength and a new fromContentProvider method in RequestBody #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quanzzzz
commented
Apr 2, 2021
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Apr 6, 2021
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
Quanzzzz
force-pushed
the
add-optional-ctlen
branch
from
387f396 to
3561850
Compare
zoewangg
reviewed
Apr 12, 2021
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
… a new fromContentProvider method allowing contentLength to be null.
Quanzzzz
force-pushed
the
add-optional-ctlen
branch
from
3561850 to
2819565
Compare
zoewangg
approved these changes
Apr 14, 2021
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 8, 2023
…ce34b352a Pull request: release <- staging/df27c771-57df-4f22-9466-8f4ce34b352a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an Optional getter for the
contentLengtha newfromContentProvidermethod allowing contentLength in classRequestBodyto be null.Description
Some APIs don't require the
Content-Lengthheader and support receiving the request body using Transfer-Encoding: chunked. For example,Lex postContent.Currently,
RequestBodyreturns a primitive long from itscontentLength()method, and all static constructors onRequestBodyrequire a content length parameter if it can't be determined automatically; e.g.fromInputStream.With the optional getter we can omit the
content-lengthfromRequestBodyso that we can fully use service operations that don't require it upfront; especially in cases where the content length can't be determined beforehand.Also, with the newly added
fromContentProvidermethod theRequestBodycan be created with anullcontent-length when thecontent-lengthis not needed.Testing
Corresponding unit test is added.