Skip to content

Remove C2j models from SDK JARs #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
breedloj opened this issue Feb 10, 2022 · 6 comments
Closed
1 task

Remove C2j models from SDK JARs #3022

breedloj opened this issue Feb 10, 2022 · 6 comments
Labels
feature-request A feature should be added or improved.

Comments

@breedloj
Copy link

breedloj commented Feb 10, 2022

Describe the feature

C2j model files are currently included in service client JARs. These can be pretty hefty (in the case of EC2, around 2.5mb altogether). They do not seem to be providing any value once clients are generated and can be fetched from source. For clients this adds quite a bit of needless overhead to deployable artifacts or shipped software.

Is your Feature Request related to a problem?

The AWS SDK dependencies within the AWS Toolkit for Jetbrains represent the largest chunk of our overall footprint (which is ~50MB). We are trying to reduce this to make it faster to distribute the Toolkit to clients and across remote machines. This change would be a good first step to trimming some fat.

Proposed Solution

Remove C2j model JSON files from generated client JARs.

Describe alternatives you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Java SDK version used

2.17.76

JDK version used

N/A

Operating System and version

N/A

@breedloj breedloj added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2022
@debora-ito debora-ito transferred this issue from aws/aws-sdk-java Feb 10, 2022
@debora-ito
Copy link
Member

Transferred to Java SDK v2 repo. Reducing size is also interesting for Lambda use cases. Will bring this up to the team.

@debora-ito debora-ito added needs-review This issue or PR needs review from the team. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2022
@debora-ito debora-ito self-assigned this Feb 10, 2022
@debora-ito
Copy link
Member

Feature request added to the backlog.

@debora-ito debora-ito removed the needs-review This issue or PR needs review from the team. label Feb 11, 2022
@debora-ito debora-ito removed their assignment Feb 11, 2022
@millems
Copy link
Contributor

millems commented Feb 16, 2022

This has been fixed with #3030

@millems millems closed this as completed Feb 16, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@vigoo
Copy link

vigoo commented Feb 17, 2022

Hi, the https://github.com/zio/zio-aws project was depending on these resources embedded in the JARs. Would you consider publishing them separately (maybe bundled in a single JAR)?

If not we will have to pull them directly from this repo as part of the code generation process.

@millems
Copy link
Contributor

millems commented Feb 17, 2022

We don't currently have a great alternative other than pulling directly from this repo, and we even intend to remove that in the future in favor of smithy models. I've reached out to our modeling team internally so that we can find a solution long-term to make models available for you, but it might take some time to get aligned on internally. I'm sorry that this broke your use-case.

aws-sdk-java-automation added a commit that referenced this issue May 6, 2024
…d15716a4b

Pull request: release <- staging/a73efa5b-699d-4b5d-8559-a57d15716a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants