Skip to content

ResponseStream underlying buffer improvements #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2023
Merged

ResponseStream underlying buffer improvements #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3877c5a
[aws-cpp-sdk-core]: do not flush ResponseStream before deletion
grrtrr Jan 30, 2023
0a2f1d7
TransferManager to flush io stream before complete notification on do…
SergeyRyabinin Feb 16, 2023
141fba5
ResponseStream to register callback on underlying stream pointer to a…
SergeyRyabinin Feb 16, 2023
84dd2ed
Regenerate clients to add const on Get ios objects
SergeyRyabinin Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-apigateway/include/aws/apigateway/model/GetExportResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ namespace Model
/**
* <p>The binary blob response to GetExport, which contains the export.</p>
*/
inline Aws::IOStream& GetBody() { return m_body.GetUnderlyingStream(); }
inline Aws::IOStream& GetBody() const { return m_body.GetUnderlyingStream(); }

/**
* <p>The binary blob response to GetExport, which contains the export.</p>
Expand All @@ -138,7 +138,7 @@ namespace Model

Aws::String m_contentDisposition;

Aws::Utils::Stream::ResponseStream m_body;
Aws::Utils::Stream::ResponseStream m_body;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-apigateway/include/aws/apigateway/model/GetSdkResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ namespace Model
/**
* <p>The binary blob response to GetSdk, which contains the generated SDK.</p>
*/
inline Aws::IOStream& GetBody() { return m_body.GetUnderlyingStream(); }
inline Aws::IOStream& GetBody() const { return m_body.GetUnderlyingStream(); }

/**
* <p>The binary blob response to GetSdk, which contains the generated SDK.</p>
Expand All @@ -131,7 +131,7 @@ namespace Model

Aws::String m_contentDisposition;

Aws::Utils::Stream::ResponseStream m_body;
Aws::Utils::Stream::ResponseStream m_body;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-apigatewayv2/include/aws/apigatewayv2/model/ExportApiResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ namespace Model



inline Aws::IOStream& GetBody() { return m_body.GetUnderlyingStream(); }
inline Aws::IOStream& GetBody() const { return m_body.GetUnderlyingStream(); }


inline void ReplaceBody(Aws::IOStream* body) { m_body = Aws::Utils::Stream::ResponseStream(body); }

private:

Aws::Utils::Stream::ResponseStream m_body;
Aws::Utils::Stream::ResponseStream m_body;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions ...ws-cpp-sdk-appconfig/include/aws/appconfig/model/CreateHostedConfigurationVersionResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ namespace Model
/**
* <p>The content of the configuration or the configuration data.</p>
*/
inline Aws::IOStream& GetContent() { return m_content.GetUnderlyingStream(); }
inline Aws::IOStream& GetContent() const { return m_content.GetUnderlyingStream(); }

/**
* <p>The content of the configuration or the configuration data.</p>
Expand Down Expand Up @@ -267,7 +267,7 @@ namespace Model

Aws::String m_description;

Aws::Utils::Stream::ResponseStream m_content;
Aws::Utils::Stream::ResponseStream m_content;

Aws::String m_contentType;

Expand Down
4 changes: 2 additions & 2 deletions ...c/aws-cpp-sdk-appconfig/include/aws/appconfig/model/GetHostedConfigurationVersionResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ namespace Model
/**
* <p>The content of the configuration or the configuration data.</p>
*/
inline Aws::IOStream& GetContent() { return m_content.GetUnderlyingStream(); }
inline Aws::IOStream& GetContent() const { return m_content.GetUnderlyingStream(); }

/**
* <p>The content of the configuration or the configuration data.</p>
Expand Down Expand Up @@ -267,7 +267,7 @@ namespace Model

Aws::String m_description;

Aws::Utils::Stream::ResponseStream m_content;
Aws::Utils::Stream::ResponseStream m_content;

Aws::String m_contentType;

Expand Down
4 changes: 2 additions & 2 deletions .../aws-cpp-sdk-appconfigdata/include/aws/appconfigdata/model/GetLatestConfigurationResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ namespace Model
* <p>The data of the configuration. This may be empty if the client already has
* the latest version of configuration.</p>
*/
inline Aws::IOStream& GetConfiguration() { return m_configuration.GetUnderlyingStream(); }
inline Aws::IOStream& GetConfiguration() const { return m_configuration.GetUnderlyingStream(); }

/**
* <p>The data of the configuration. This may be empty if the client already has
Expand Down Expand Up @@ -243,7 +243,7 @@ namespace Model

Aws::String m_contentType;

Aws::Utils::Stream::ResponseStream m_configuration;
Aws::Utils::Stream::ResponseStream m_configuration;

Aws::String m_versionLabel;
};
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-appsync/include/aws/appsync/model/GetIntrospectionSchemaResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace Model
* more information, see the <a href="http://graphql.org/learn/schema/">GraphQL SDL
* documentation</a>.</p>
*/
inline Aws::IOStream& GetSchema() { return m_schema.GetUnderlyingStream(); }
inline Aws::IOStream& GetSchema() const { return m_schema.GetUnderlyingStream(); }

/**
* <p>The schema, in GraphQL Schema Definition Language (SDL) format.</p> <p>For
Expand All @@ -52,7 +52,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_schema;
Aws::Utils::Stream::ResponseStream m_schema;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-backupstorage/include/aws/backupstorage/model/GetChunkResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace Model
/**
* Chunk data
*/
inline Aws::IOStream& GetData() { return m_data.GetUnderlyingStream(); }
inline Aws::IOStream& GetData() const { return m_data.GetUnderlyingStream(); }

/**
* Chunk data
Expand Down Expand Up @@ -128,7 +128,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_data;
Aws::Utils::Stream::ResponseStream m_data;

long long m_length;

Expand Down
4 changes: 2 additions & 2 deletions ...d/src/aws-cpp-sdk-backupstorage/include/aws/backupstorage/model/GetObjectMetadataResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ namespace Model
/**
* Metadata blob.
*/
inline Aws::IOStream& GetMetadataBlob() { return m_metadataBlob.GetUnderlyingStream(); }
inline Aws::IOStream& GetMetadataBlob() const { return m_metadataBlob.GetUnderlyingStream(); }

/**
* Metadata blob.
Expand Down Expand Up @@ -166,7 +166,7 @@ namespace Model

Aws::String m_metadataString;

Aws::Utils::Stream::ResponseStream m_metadataBlob;
Aws::Utils::Stream::ResponseStream m_metadataBlob;

long long m_metadataBlobLength;

Expand Down
4 changes: 2 additions & 2 deletions ...ted/src/aws-cpp-sdk-cloudfront/include/aws/cloudfront/model/GetFunction2020_05_31Result.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace Model
/**
* <p>The function code of a CloudFront function.</p>
*/
inline Aws::IOStream& GetFunctionCode() { return m_functionCode.GetUnderlyingStream(); }
inline Aws::IOStream& GetFunctionCode() const { return m_functionCode.GetUnderlyingStream(); }

/**
* <p>The function code of a CloudFront function.</p>
Expand Down Expand Up @@ -128,7 +128,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_functionCode;
Aws::Utils::Stream::ResponseStream m_functionCode;

Aws::String m_eTag;

Expand Down
4 changes: 2 additions & 2 deletions ...rc/aws-cpp-sdk-codeartifact/include/aws/codeartifact/model/GetPackageVersionAssetResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace Model
/**
* <p> The binary file, or asset, that is downloaded.</p>
*/
inline Aws::IOStream& GetAsset() { return m_asset.GetUnderlyingStream(); }
inline Aws::IOStream& GetAsset() const { return m_asset.GetUnderlyingStream(); }

/**
* <p> The binary file, or asset, that is downloaded.</p>
Expand Down Expand Up @@ -171,7 +171,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_asset;
Aws::Utils::Stream::ResponseStream m_asset;

Aws::String m_assetName;

Expand Down
4 changes: 2 additions & 2 deletions ...ed/src/aws-cpp-sdk-codeguruprofiler/include/aws/codeguruprofiler/model/GetProfileResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ namespace Model
/**
* <p>Information about the profile.</p>
*/
inline Aws::IOStream& GetProfile() { return m_profile.GetUnderlyingStream(); }
inline Aws::IOStream& GetProfile() const { return m_profile.GetUnderlyingStream(); }

/**
* <p>Information about the profile.</p>
Expand All @@ -145,7 +145,7 @@ namespace Model

Aws::String m_contentType;

Aws::Utils::Stream::ResponseStream m_profile;
Aws::Utils::Stream::ResponseStream m_profile;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-dataexchange/include/aws/dataexchange/model/SendApiAssetResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace Model
/**
* <p>The response body from the underlying API tracked by the API asset.</p>
*/
inline Aws::IOStream& GetBody() { return m_body.GetUnderlyingStream(); }
inline Aws::IOStream& GetBody() const { return m_body.GetUnderlyingStream(); }

/**
* <p>The response body from the underlying API tracked by the API asset.</p>
Expand Down Expand Up @@ -110,7 +110,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_body;
Aws::Utils::Stream::ResponseStream m_body;

Aws::Map<Aws::String, Aws::String> m_responseHeaders;
};
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-ebs/include/aws/ebs/model/GetSnapshotBlockResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace Model
/**
* <p>The data content of the block.</p>
*/
inline Aws::IOStream& GetBlockData() { return m_blockData.GetUnderlyingStream(); }
inline Aws::IOStream& GetBlockData() const { return m_blockData.GetUnderlyingStream(); }

/**
* <p>The data content of the block.</p>
Expand Down Expand Up @@ -135,7 +135,7 @@ namespace Model

int m_dataLength;

Aws::Utils::Stream::ResponseStream m_blockData;
Aws::Utils::Stream::ResponseStream m_blockData;

Aws::String m_checksum;

Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-glacier/include/aws/glacier/model/GetJobOutputResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ namespace Model
/**
* <p>The job data, either archive data or inventory data.</p>
*/
inline Aws::IOStream& GetBody() { return m_body.GetUnderlyingStream(); }
inline Aws::IOStream& GetBody() const { return m_body.GetUnderlyingStream(); }

/**
* <p>The job data, either archive data or inventory data.</p>
Expand Down Expand Up @@ -380,7 +380,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_body;
Aws::Utils::Stream::ResponseStream m_body;

Aws::String m_checksum;

Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-iot-data/include/aws/iot-data/model/DeleteThingShadowResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace Model
/**
* <p>The state information, in JSON format.</p>
*/
inline Aws::IOStream& GetPayload() { return m_payload.GetUnderlyingStream(); }
inline Aws::IOStream& GetPayload() const { return m_payload.GetUnderlyingStream(); }

/**
* <p>The state information, in JSON format.</p>
Expand All @@ -54,7 +54,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_payload;
Aws::Utils::Stream::ResponseStream m_payload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-iot-data/include/aws/iot-data/model/GetThingShadowResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace Model
/**
* <p>The state information, in JSON format.</p>
*/
inline Aws::IOStream& GetPayload() { return m_payload.GetUnderlyingStream(); }
inline Aws::IOStream& GetPayload() const { return m_payload.GetUnderlyingStream(); }

/**
* <p>The state information, in JSON format.</p>
Expand All @@ -53,7 +53,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_payload;
Aws::Utils::Stream::ResponseStream m_payload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions generated/src/aws-cpp-sdk-iot-data/include/aws/iot-data/model/UpdateThingShadowResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace Model
/**
* <p>The state information, in JSON format.</p>
*/
inline Aws::IOStream& GetPayload() { return m_payload.GetUnderlyingStream(); }
inline Aws::IOStream& GetPayload() const { return m_payload.GetUnderlyingStream(); }

/**
* <p>The state information, in JSON format.</p>
Expand All @@ -54,7 +54,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_payload;
Aws::Utils::Stream::ResponseStream m_payload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions ...ted/src/aws-cpp-sdk-iotwireless/include/aws/iotwireless/model/GetPositionEstimateResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace Model
* data structures. For more information, see <a
* href="https://geojson.org/">GeoJSON</a>.</p>
*/
inline Aws::IOStream& GetGeoJsonPayload() { return m_geoJsonPayload.GetUnderlyingStream(); }
inline Aws::IOStream& GetGeoJsonPayload() const { return m_geoJsonPayload.GetUnderlyingStream(); }

/**
* <p>The position information of the resource, displayed as a JSON payload. The
Expand All @@ -54,7 +54,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_geoJsonPayload;
Aws::Utils::Stream::ResponseStream m_geoJsonPayload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions ...ted/src/aws-cpp-sdk-iotwireless/include/aws/iotwireless/model/GetResourcePositionResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace Model
* data structures. For more information, see <a
* href="https://geojson.org/">GeoJSON</a>.</p>
*/
inline Aws::IOStream& GetGeoJsonPayload() { return m_geoJsonPayload.GetUnderlyingStream(); }
inline Aws::IOStream& GetGeoJsonPayload() const { return m_geoJsonPayload.GetUnderlyingStream(); }

/**
* <p>The position information of the resource, displayed as a JSON payload. The
Expand All @@ -54,7 +54,7 @@ namespace Model

private:

Aws::Utils::Stream::ResponseStream m_geoJsonPayload;
Aws::Utils::Stream::ResponseStream m_geoJsonPayload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions ...nesis-video-archived-media/include/aws/kinesis-video-archived-media/model/GetClipResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ namespace Model
* href="https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/limits.html">Kinesis
* Video Streams Limits</a>. </p>
*/
inline Aws::IOStream& GetPayload() { return m_payload.GetUnderlyingStream(); }
inline Aws::IOStream& GetPayload() const { return m_payload.GetUnderlyingStream(); }

/**
* <p>Traditional MP4 file that contains the media clip from the specified video
Expand All @@ -95,7 +95,7 @@ namespace Model

Aws::String m_contentType;

Aws::Utils::Stream::ResponseStream m_payload;
Aws::Utils::Stream::ResponseStream m_payload;
};

} // namespace Model
Expand Down
4 changes: 2 additions & 2 deletions ...ived-media/include/aws/kinesis-video-archived-media/model/GetMediaForFragmentListResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ namespace Model
* code of the exception</p> </li> <li> <p>AWS_KINESISVIDEO_EXCEPTION_MESSAGE - A
* text description of the exception</p> </li> </ul>
*/
inline Aws::IOStream& GetPayload() { return m_payload.GetUnderlyingStream(); }
inline Aws::IOStream& GetPayload() const { return m_payload.GetUnderlyingStream(); }

/**
* <p>The payload that Kinesis Video Streams returns is a sequence of chunks from
Expand All @@ -115,7 +115,7 @@ namespace Model

Aws::String m_contentType;

Aws::Utils::Stream::ResponseStream m_payload;
Aws::Utils::Stream::ResponseStream m_payload;
};

} // namespace Model
Expand Down
Loading