Skip to content

Updated sample App CMake definition to not depend on larger project internals #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

sdavtaker
Copy link
Contributor

@sdavtaker sdavtaker commented Feb 16, 2023

Issue #1888

Description of changes:
Updated sample App CMake definition to not depend on larger project internals.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdavtaker sdavtaker force-pushed the legacy_wrap branch 2 times, most recently from 93fd61c to b4f68b2 Compare February 16, 2023 16:55
@sdavtaker sdavtaker changed the title Wrapping LEGACY_BUILD code in cmake and src Updated sample App CMake definition to not depend on larger project internals Feb 16, 2023
@sdavtaker sdavtaker marked this pull request as ready for review February 16, 2023 17:41
@SergeyRyabinin SergeyRyabinin self-requested a review February 16, 2023 17:48
@sdavtaker sdavtaker force-pushed the legacy_wrap branch 4 times, most recently from a9a064c to 4ae3f56 Compare February 16, 2023 20:33
@sdavtaker sdavtaker merged commit 2e7baae into main Feb 16, 2023
@sdavtaker sdavtaker deleted the legacy_wrap branch February 16, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants