[aws-cpp-sdk-core]: do not flush ResponseStream before deletion #2320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing the
ResponseStream
before deletion causes undefined behaviour and segmentation faults, since theResponseStream
is destructed after the actual download has completed.Resolves #58, #2319 and in part #1732.
Check all that applies:
Tested with a reproducing command (which reliably produced the segmentation fault described in [aws-cpp-sdk-core] undefined behaviour when flushing ResponseStream before deletion #2319) that the condition no longer occurs after applying this change.
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.