Skip to content

fixes build all target #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Cmake refactor broke the build all target for default builds, This fixes it.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdavtaker sdavtaker self-requested a review May 17, 2022 12:43
@@ -72,7 +72,7 @@ endfunction()
# services have the name format abc.def.ghi will be renamed to ghi-def-abc (dot will not be accepted as Windows directory name )
# and put into C2J_SPECIAL_NAME_LIST, but rumtime.lex will be renamed to lex based on historical reason.
function(build_sdk_list)
file(GLOB ALL_MODEL_FILES "${CMAKE_CURRENT_SOURCE_DIR}/code-generation/api-descriptions/*-[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9].normal.json")
file(GLOB ALL_MODEL_FILES "${CMAKE_CURRENT_SOURCE_DIR}/tools/code-generation/api-descriptions/*-[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9].normal.json")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooooh! :)

@sdavtaker sdavtaker marked this pull request as ready for review May 17, 2022 12:47
@sbiscigl sbiscigl merged commit b45643b into build-dev-1.10-pr5 May 17, 2022
@sbiscigl sbiscigl deleted the build-dev-1.10-fix-all-target branch May 17, 2022 15:53
sdavtaker pushed a commit that referenced this pull request May 18, 2022
@sdavtaker sdavtaker mentioned this pull request May 26, 2022
11 tasks
@sdavtaker sdavtaker mentioned this pull request Aug 18, 2022
11 tasks
sdavtaker pushed a commit that referenced this pull request Aug 23, 2022
sdavtaker pushed a commit that referenced this pull request Sep 2, 2022
@sdavtaker sdavtaker mentioned this pull request Oct 6, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants