Skip to content

Commit 95fc5a9

Browse files
committed
Prometheus add nodes gauge for SQS mode
1 parent 498fc02 commit 95fc5a9

37 files changed

+1189
-201
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,9 @@
22

33
**Description of changes:**
44

5+
**How you tested your changes:**
6+
Environment (Linux / Windows):
7+
Kubernetes Version:
8+
59

610
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/workflows/build-and-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
- name: Set up golangci-lint
7171
uses: golangci/golangci-lint-action@v3
7272
with:
73-
version: v1.55.2
73+
version: latest
7474
args: --timeout=5m
7575
skip-cache: true
7676

@@ -191,7 +191,7 @@ jobs:
191191
runs-on: ubuntu-20.04
192192
strategy:
193193
matrix:
194-
k8sVersion: ["1.23", "1.24", "1.25", "1.26", "1.27", "1.28", "1.29", "1.30"]
194+
k8sVersion: ["1.29", "1.30", "1.31"]
195195
steps:
196196
- name: Set up Go 1.x
197197
uses: actions/setup-go@v2

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ upload-resources-to-github-windows:
160160

161161
generate-k8s-yaml:
162162
${MAKEFILE_PATH}/scripts/generate-k8s-yaml
163-
${MAKEFILE_PATH}/scripts/generate-k8s-yaml -k "1.25.0" -s ${K8S_1_25_ASSET_SUFFIX}
163+
${MAKEFILE_PATH}/scripts/generate-k8s-yaml -k "1.31.2" -s ${K8S_1_25_ASSET_SUFFIX}
164164

165165
sync-readme-to-ecr-public:
166166
@ECR_REGISTRY=${ECR_REGISTRY} ${MAKEFILE_PATH}/scripts/ecr-public-login

README.md

Lines changed: 36 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,21 @@ When using the EC2 Console or EC2 API to terminate the instance, a state-change
8383
| Spot Instance Termination Notifications (ITN) |||
8484
| Scheduled Events |||
8585
| Instance Rebalance Recommendation |||
86-
| ASG Termination Lifecycle Hooks | ||
86+
| ASG Termination Lifecycle Hooks | ||
8787
| AZ Rebalance Recommendation |||
8888
| Instance State Change Events |||
8989

9090
### Kubernetes Compatibility
9191

92-
| NTH Release | K8s v1.30 | K8s v1.29 | K8s v1.28 | K8s v1.27 | K8s v1.26 | K8s v1.25 | K8s v1.24 | K8s v1.23 |
93-
| :-----------------------------------------------------------------------------------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: |
94-
| [v1.22.1](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.22.1) |||||||||
95-
| [v1.22.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.22.0) |||||||||
96-
| [v1.21.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.21.0) |||||||||
97-
| [v1.20.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.20.0) |||||||||
98-
| [v1.19.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.19.0) |||||||||
92+
| NTH Release | K8s v1.31 | K8s v1.30 | K8s v1.29 | K8s v1.28 | K8s v1.27 | K8s v1.26 | K8s v1.25 | K8s v1.24 | K8s v1.23 |
93+
| :-----------------------------------------------------------------------------------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: | :-------: |
94+
| [v1.23.1](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.23.1) ||||||||||
95+
| [v1.23.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.23.0) ||||||||||
96+
| [v1.22.1](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.22.1) ||||||||||
97+
| [v1.22.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.22.0) ||||||||||
98+
| [v1.21.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.21.0) ||||||||||
99+
| [v1.20.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.20.0) ||||||||||
100+
| [v1.19.0](https://github.com/aws/aws-node-termination-handler/releases/tag/v1.19.0) ||||||||||
99101

100102
A ✅ indicates that a specific aws-node-termination-handler release has been tested with a specific Kubernetes version. A ❌ indicates that a specific aws-node-termination-handler release has not been tested with a specific Kubernetes version.
101103

@@ -135,7 +137,7 @@ When using Kubernetes [Pod Security Admission](https://kubernetes.io/docs/concep
135137
You can use kubectl to directly add all of the above resources with the default configuration into your cluster.
136138

137139
```
138-
kubectl apply -f https://github.com/aws/aws-node-termination-handler/releases/download/v1.22.1/all-resources.yaml
140+
kubectl apply -f https://github.com/aws/aws-node-termination-handler/releases/download/v1.23.1/all-resources.yaml
139141
```
140142

141143
For a full list of releases and associated artifacts see our [releases page](https://github.com/aws/aws-node-termination-handler/releases).
@@ -208,7 +210,7 @@ helm upgrade --install aws-node-termination-handler \
208210
oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler --version $CHART_VERSION
209211
```
210212

211-
For a full list of configuration options see our [Helm readme](https://github.com/aws/aws-node-termination-handler/blob/v1.22.1/config/helm/aws-node-termination-handler#readme).
213+
For a full list of configuration options see our [Helm readme](https://github.com/aws/aws-node-termination-handler/blob/v1.23.1/config/helm/aws-node-termination-handler#readme).
212214

213215
</details>
214216

@@ -498,7 +500,7 @@ helm upgrade --install aws-node-termination-handler \
498500
oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler --version $CHART_VERSION
499501
```
500502

501-
For a full list of configuration options see our [Helm readme](https://github.com/aws/aws-node-termination-handler/blob/v1.22.1/config/helm/aws-node-termination-handler#readme).
503+
For a full list of configuration options see our [Helm readme](https://github.com/aws/aws-node-termination-handler/blob/v1.23.1/config/helm/aws-node-termination-handler#readme).
502504

503505
#### Single Instance vs Multiple Replicas
504506

@@ -523,7 +525,7 @@ Queue Processor needs an **SQS queue URL** to function; therefore, manifest chan
523525
Minimal Config:
524526

525527
```
526-
curl -L https://github.com/aws/aws-node-termination-handler/releases/download/v1.22.1/all-resources-queue-processor.yaml -o all-resources-queue-processor.yaml
528+
curl -L https://github.com/aws/aws-node-termination-handler/releases/download/v1.23.1/all-resources-queue-processor.yaml -o all-resources-queue-processor.yaml
527529
<open all-resources-queue-processor.yaml and update QUEUE_URL value>
528530
kubectl apply -f ./all-resources-queue-processor.yaml
529531
```
@@ -587,6 +589,28 @@ Available Prometheus metrics:
587589
| `actions_node` | Number of actions per node (Deprecated: Use actions metric instead)|
588590
| `events_error` | Number of errors in events processing |
589591

592+
The method of collecting Prometheus metrics changes depending on whether NTH is running in IMDS mode or Queue mode.
593+
594+
> [!WARNING]
595+
> Both `serviceMonitor` and `podMonitor` are custom resources provided by the [Prometheus Operator](https://github.com/prometheus-operator/prometheus-operator) for seamless integration with Kubernetes services and pods. For more details, please refer to [the API reference docs](https://prometheus-operator.dev/docs/api-reference/api/) for the Prometheus Operator.
596+
597+
In Queue mode, metrics can be collected in two ways:
598+
- Use a `serviceMonitor` custom resource with the Prometheus Operator to collect metrics.
599+
- Alternatively, add aws-node-termination-handler service address statically in Prometheus `scrape_configs`.
600+
601+
Example `scrape_configs` in prometheus helm chart:
602+
```yaml
603+
# charts/prometheus/values.yaml
604+
# See: https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/values.yaml
605+
extraScrapeConfigs: |
606+
- job_name: 'aws-node-termination-handler'
607+
static_configs:
608+
- targets:
609+
- 'aws-node-termination-handler.kube-system.svc.cluster.local:9092'
610+
```
611+
612+
In IMDS mode, metrics can be collected as follows:
613+
- Use a `podMonitor` custom resource with the Prometheus Operator to collect metrics.
590614

591615
## Communication
592616
* If you've run into a bug or have a new feature request, please open an [issue](https://github.com/aws/aws-node-termination-handler/issues/new).

cmd/node-termination-handler.go

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ package main
1616
import (
1717
"context"
1818
"fmt"
19-
"github.com/aws/aws-node-termination-handler/pkg/monitor/asglifecycle"
2019
"os"
2120
"os/signal"
2221
"strings"
@@ -31,6 +30,7 @@ import (
3130
"github.com/aws/aws-node-termination-handler/pkg/interruptioneventstore"
3231
"github.com/aws/aws-node-termination-handler/pkg/logging"
3332
"github.com/aws/aws-node-termination-handler/pkg/monitor"
33+
"github.com/aws/aws-node-termination-handler/pkg/monitor/asglifecycle"
3434
"github.com/aws/aws-node-termination-handler/pkg/monitor/rebalancerecommendation"
3535
"github.com/aws/aws-node-termination-handler/pkg/monitor/scheduledevent"
3636
"github.com/aws/aws-node-termination-handler/pkg/monitor/spotitn"
@@ -43,7 +43,6 @@ import (
4343
"github.com/aws/aws-sdk-go/aws/session"
4444
"github.com/aws/aws-sdk-go/service/autoscaling"
4545
"github.com/aws/aws-sdk-go/service/ec2"
46-
"github.com/aws/aws-sdk-go/service/sqs"
4746
"github.com/rs/zerolog"
4847
"github.com/rs/zerolog/log"
4948
"k8s.io/apimachinery/pkg/util/wait"
@@ -121,7 +120,20 @@ func main() {
121120
log.Fatal().Err(err).Msg("Unable to instantiate a node for various kubernetes node functions,")
122121
}
123122

124-
metrics, err := observability.InitMetrics(nthConfig.EnablePrometheus, nthConfig.PrometheusPort)
123+
cfg := aws.NewConfig().WithRegion(nthConfig.AWSRegion).WithEndpoint(nthConfig.AWSEndpoint).WithSTSRegionalEndpoint(endpoints.RegionalSTSEndpoint)
124+
sess := session.Must(session.NewSessionWithOptions(session.Options{
125+
Config: *cfg,
126+
SharedConfigState: session.SharedConfigEnable,
127+
}))
128+
creds, err := sess.Config.Credentials.Get()
129+
if err != nil {
130+
log.Fatal().Err(err).Msg("Unable to get AWS credentials")
131+
}
132+
log.Debug().Msgf("AWS Credentials retrieved from provider: %s", creds.ProviderName)
133+
134+
ec2 := ec2.New(sess)
135+
136+
metrics, err := observability.InitMetrics(nthConfig, node, ec2)
125137
if err != nil {
126138
nthConfig.Print()
127139
log.Fatal().Err(err).Msg("Unable to instantiate observability metrics,")
@@ -205,27 +217,16 @@ func main() {
205217
}
206218
}
207219
if nthConfig.EnableSQSTerminationDraining {
208-
cfg := aws.NewConfig().WithRegion(nthConfig.AWSRegion).WithEndpoint(nthConfig.AWSEndpoint).WithSTSRegionalEndpoint(endpoints.RegionalSTSEndpoint)
209-
sess := session.Must(session.NewSessionWithOptions(session.Options{
210-
Config: *cfg,
211-
SharedConfigState: session.SharedConfigEnable,
212-
}))
213-
creds, err := sess.Config.Credentials.Get()
214-
if err != nil {
215-
log.Fatal().Err(err).Msg("Unable to get AWS credentials")
216-
}
217-
log.Debug().Msgf("AWS Credentials retrieved from provider: %s", creds.ProviderName)
218-
219220
completeLifecycleActionDelay := time.Duration(nthConfig.CompleteLifecycleActionDelaySeconds) * time.Second
220221
sqsMonitor := sqsevent.SQSMonitor{
221222
CheckIfManaged: nthConfig.CheckTagBeforeDraining,
222223
ManagedTag: nthConfig.ManagedTag,
223224
QueueURL: nthConfig.QueueURL,
224225
InterruptionChan: interruptionChan,
225226
CancelChan: cancelChan,
226-
SQS: sqs.New(sess),
227+
SQS: sqsevent.GetSqsClient(sess),
227228
ASG: autoscaling.New(sess),
228-
EC2: ec2.New(sess),
229+
EC2: ec2,
229230
BeforeCompleteLifecycleAction: func() { <-time.After(completeLifecycleActionDelay) },
230231
}
231232
monitoringFns[sqsEvents] = sqsMonitor

config/helm/aws-node-termination-handler/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ apiVersion: v2
22
name: aws-node-termination-handler
33
description: A Helm chart for the AWS Node Termination Handler.
44
type: application
5-
version: 0.24.1
6-
appVersion: 1.22.1
5+
version: 0.25.1
6+
appVersion: 1.23.1
77
kubeVersion: ">= 1.16-0"
88
keywords:
99
- aws

go.mod

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ require (
1515
go.opentelemetry.io/otel/metric v1.29.0
1616
go.opentelemetry.io/otel/sdk/metric v1.29.0
1717
go.uber.org/multierr v1.11.0
18-
golang.org/x/sys v0.24.0
18+
golang.org/x/sys v0.28.0
1919
k8s.io/api v0.30.4
2020
k8s.io/apimachinery v0.30.4
2121
k8s.io/client-go v0.30.4
@@ -85,12 +85,12 @@ require (
8585
go.opentelemetry.io/otel/sdk v1.29.0 // indirect
8686
go.opentelemetry.io/otel/trace v1.29.0 // indirect
8787
go.starlark.net v0.0.0-20230525235612-a134d8f9ddca // indirect
88-
golang.org/x/crypto v0.24.0 // indirect
89-
golang.org/x/net v0.26.0 // indirect
88+
golang.org/x/crypto v0.31.0 // indirect
89+
golang.org/x/net v0.33.0 // indirect
9090
golang.org/x/oauth2 v0.21.0 // indirect
91-
golang.org/x/sync v0.7.0 // indirect
92-
golang.org/x/term v0.21.0 // indirect
93-
golang.org/x/text v0.16.0 // indirect
91+
golang.org/x/sync v0.10.0 // indirect
92+
golang.org/x/term v0.27.0 // indirect
93+
golang.org/x/text v0.21.0 // indirect
9494
golang.org/x/time v0.3.0 // indirect
9595
google.golang.org/protobuf v1.34.2 // indirect
9696
gopkg.in/inf.v0 v0.9.1 // indirect

go.sum

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,8 @@ golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8U
236236
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
237237
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
238238
golang.org/x/crypto v0.3.0/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4=
239-
golang.org/x/crypto v0.24.0 h1:mnl8DM0o513X8fdIkmyFE/5hTYxbwYOjDS/+rK6qpRI=
240-
golang.org/x/crypto v0.24.0/go.mod h1:Z1PMYSOR5nyMcyAVAIQSKCDwalqy85Aqn1x3Ws4L5DM=
239+
golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=
240+
golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk=
241241
golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
242242
golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
243243
golang.org/x/lint v0.0.0-20190227174305-5b3e6a55c961/go.mod h1:wehouNa3lNwaWXcvxsM5YxQ5yQlVC4a0KAMCusXpPoU=
@@ -256,8 +256,8 @@ golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwY
256256
golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
257257
golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c=
258258
golang.org/x/net v0.2.0/go.mod h1:KqCZLdyyvdV855qA2rE3GC2aiw5xGR5TEjj8smXukLY=
259-
golang.org/x/net v0.26.0 h1:soB7SVo0PWrY4vPW/+ay0jKDNScG2X9wFeYlXIvJsOQ=
260-
golang.org/x/net v0.26.0/go.mod h1:5YKkiSynbBIh3p6iOc/vibscux0x38BZDkn8sCUPxHE=
259+
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
260+
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
261261
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
262262
golang.org/x/oauth2 v0.21.0 h1:tsimM75w1tF/uws5rbeHzIWxEqElMehnc+iW793zsZs=
263263
golang.org/x/oauth2 v0.21.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
@@ -267,8 +267,8 @@ golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJ
267267
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
268268
golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
269269
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
270-
golang.org/x/sync v0.7.0 h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M=
271-
golang.org/x/sync v0.7.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
270+
golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
271+
golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
272272
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
273273
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
274274
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
@@ -282,20 +282,20 @@ golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBc
282282
golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
283283
golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
284284
golang.org/x/sys v0.2.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
285-
golang.org/x/sys v0.24.0 h1:Twjiwq9dn6R1fQcyiK+wQyHWfaz/BJB+YIpzU/Cv3Xg=
286-
golang.org/x/sys v0.24.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
285+
golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
286+
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
287287
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
288288
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
289289
golang.org/x/term v0.0.0-20220526004731-065cf7ba2467/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
290290
golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc=
291-
golang.org/x/term v0.21.0 h1:WVXCp+/EBEHOj53Rvu+7KiT/iElMrO8ACK16SMZ3jaA=
292-
golang.org/x/term v0.21.0/go.mod h1:ooXLefLobQVslOqselCNF4SxFAaoS6KujMbsGzSDmX0=
291+
golang.org/x/term v0.27.0 h1:WP60Sv1nlK1T6SupCHbXzSaN0b9wUmsPoRS9b61A23Q=
292+
golang.org/x/term v0.27.0/go.mod h1:iMsnZpn0cago0GOrHO2+Y7u7JPn5AylBrcoWkElMTSM=
293293
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
294294
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
295295
golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
296296
golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
297-
golang.org/x/text v0.16.0 h1:a94ExnEXNtEwYLGJSIUxnWoxoRz/ZcCsV63ROupILh4=
298-
golang.org/x/text v0.16.0/go.mod h1:GhwF1Be+LQoKShO3cGOHzqOgRrGaYc9AvblQOmPVHnI=
297+
golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
298+
golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
299299
golang.org/x/time v0.3.0 h1:rg5rLMjNzMS1RkNLzCG38eapWhnYLFYXDXj2gOlr8j4=
300300
golang.org/x/time v0.3.0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
301301
golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=

pkg/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const (
5454
enableSpotInterruptionDrainingConfigKey = "ENABLE_SPOT_INTERRUPTION_DRAINING"
5555
enableSpotInterruptionDrainingDefault = true
5656
enableASGLifecycleDrainingConfigKey = "ENABLE_ASG_LIFECYCLE_DRAINING"
57-
enableASGLifecycleDrainingDefault = true
57+
enableASGLifecycleDrainingDefault = false
5858
enableSQSTerminationDrainingConfigKey = "ENABLE_SQS_TERMINATION_DRAINING"
5959
enableSQSTerminationDrainingDefault = false
6060
enableRebalanceMonitoringConfigKey = "ENABLE_REBALANCE_MONITORING"

0 commit comments

Comments
 (0)