add ec2metadata new tests to check for optional paths

Signed-off-by: Xabier Napal <[email protected]>

Author: xabinapal

pkg/ec2metadata/ec2metadata_test.go

@@ -611,7 +611,57 @@ func TestGetMetadataServiceRequest404(t *testing.T) {
 
 	_, err := imds.GetMetadataInfo(requestPath, false)
 
-	h.Assert(t, err != nil, "Expected error to be nil but it was not")
+	h.Assert(t, err != nil, "Error expected because request errored with 404")
+}
+
+func TestGetMetadataServiceRequest404AllowMissing(t *testing.T) {
+	var requestPath string = "/latest/meta-data/instance-type"
+
+	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+		rw.Header().Add("X-aws-ec2-metadata-token-ttl-seconds", "100")
+		if req.URL.String() == "/latest/api/token" {
+			rw.WriteHeader(200)
+			_, err := rw.Write([]byte(`token`))
+			h.Ok(t, err)
+			return
+		}
+		h.Equals(t, req.Header.Get("X-aws-ec2-metadata-token"), "token")
+		h.Equals(t, req.URL.String(), requestPath)
+		rw.WriteHeader(404)
+	}))
+	defer server.Close()
+
+	// Use URL from our local test server
+	imds := ec2metadata.New(server.URL, 1)
+
+	_, err := imds.GetMetadataInfo(requestPath, true)
+
+	h.Assert(t, err == nil, "Expected error to be nil but it was not")
+}
+
+func TestGetMetadataServiceRequest500AllowMissing(t *testing.T) {
+	var requestPath string = "/latest/meta-data/instance-type"
+
+	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+		rw.Header().Add("X-aws-ec2-metadata-token-ttl-seconds", "100")
+		if req.URL.String() == "/latest/api/token" {
+			rw.WriteHeader(200)
+			_, err := rw.Write([]byte(`token`))
+			h.Ok(t, err)
+			return
+		}
+		h.Equals(t, req.Header.Get("X-aws-ec2-metadata-token"), "token")
+		h.Equals(t, req.URL.String(), requestPath)
+		rw.WriteHeader(500)
+	}))
+	defer server.Close()
+
+	// Use URL from our local test server
+	imds := ec2metadata.New(server.URL, 1)
+
+	_, err := imds.GetMetadataInfo(requestPath, true)
+
+	h.Assert(t, err != nil, "Error expected because request errored with 500")
 }
 
 func TestGetMetadataServiceRequestFailure(t *testing.T) {