Fix & improve formatting in Readme #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix indentation in the "To build the emulator into your image" section
- This fixes the indentation level and also fixes some code blocks to be
rendered correctly
2. Add some syntax highlighting
lionralfs
reviewed
Dec 31, 2022
| ``` | ||
| https://github.com/aws/aws-lambda-runtime-interface-emulator/releases/latest/download/aws-lambda-rie-arm64 \ | ||
| ``` | ||
|
|
||
| 2. Run your Lambda image function using the docker run command. | ||
| ``` | ||
| ```sh | ||
| docker run -d -v ~/.aws-lambda-rie:/aws-lambda -p 9000:8080 myfunction:latest | ||
| --entrypoint /aws-lambda/aws-lambda-rie <image entrypoint> <(optional) image command>` |
There was a problem hiding this comment.
While we're at it ;)
Suggested change
| --entrypoint /aws-lambda/aws-lambda-rie <image entrypoint> <(optional) image command>` | |
| --entrypoint /aws-lambda/aws-lambda-rie <image entrypoint> <(optional) image command> |
ghost
mentioned this pull request
|
Thank you for opening this pull request! We appreciate your contribution and the time you took to make this improvement. However, we have recently merged pull request #81 which implements similar changes to this pull request. As a result, we will be closing this pull request. Thank you for your understanding. We appreciate your efforts and look forward to your future contributions to the project. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendered correctly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.