Skip to content

fix: staticcheck warnings in events/codebuild.go #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2020
Merged

fix: staticcheck warnings in events/codebuild.go #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49451ab
fix: staticcheck warnings in events/codebuild.go
shogo82148 Sep 19, 2020
b99d161
Merge branch 'master' into fix-sa9004-code-build
bmoffatt Oct 3, 2020
8ac6435
Merge branch 'master' into fix-sa9004-code-build
bmoffatt Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,3 @@ run:
skip-files:
# These were code-generated, and cannot be changed without breaking RPC compatibility.
- lambda/messages/*.go

# FIXME
# events/codebuild.go:18:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
# CodeBuildPhaseStatusFailed CodeBuildPhaseStatus = "FAILED"
# ^
# events/codebuild.go:31:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
# CodeBuildPhaseTypeSubmitted CodeBuildPhaseType = "SUBMITTED"
# ^
- events/codebuild.go
36 changes: 18 additions & 18 deletions events/codebuild.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,29 @@ type CodeBuildPhaseStatus string

const (
CodeBuildPhaseStatusFailed CodeBuildPhaseStatus = "FAILED"
CodeBuildPhaseStatusFault = "FAULT"
CodeBuildPhaseStatusInProgress = "IN_PROGRESS"
CodeBuildPhaseStatusQueued = "QUEUED"
CodeBuildPhaseStatusStopped = "STOPPED"
CodeBuildPhaseStatusSucceeded = "SUCCEEDED"
CodeBuildPhaseStatusTimedOut = "TIMED_OUT"
CodeBuildPhaseStatusFault CodeBuildPhaseStatus = "FAULT"
CodeBuildPhaseStatusInProgress CodeBuildPhaseStatus = "IN_PROGRESS"
CodeBuildPhaseStatusQueued CodeBuildPhaseStatus = "QUEUED"
CodeBuildPhaseStatusStopped CodeBuildPhaseStatus = "STOPPED"
CodeBuildPhaseStatusSucceeded CodeBuildPhaseStatus = "SUCCEEDED"
CodeBuildPhaseStatusTimedOut CodeBuildPhaseStatus = "TIMED_OUT"
)

// CodeBuildPhaseType represents the type of the code build phase (i.e. submitted, install)
type CodeBuildPhaseType string

const (
CodeBuildPhaseTypeSubmitted CodeBuildPhaseType = "SUBMITTED"
CodeBuildPhaseTypeQueued = "QUEUED"
CodeBuildPhaseTypeProvisioning = "PROVISIONING"
CodeBuildPhaseTypeDownloadSource = "DOWNLOAD_SOURCE"
CodeBuildPhaseTypeInstall = "INSTALL"
CodeBuildPhaseTypePreBuild = "PRE_BUILD"
CodeBuildPhaseTypeBuild = "BUILD"
CodeBuildPhaseTypePostBuild = "POST_BUILD"
CodeBuildPhaseTypeUploadArtifacts = "UPLOAD_ARTIFACTS"
CodeBuildPhaseTypeFinalizing = "FINALIZING"
CodeBuildPhaseTypeCompleted = "COMPLETED"
CodeBuildPhaseTypeQueued CodeBuildPhaseType = "QUEUED"
CodeBuildPhaseTypeProvisioning CodeBuildPhaseType = "PROVISIONING"
CodeBuildPhaseTypeDownloadSource CodeBuildPhaseType = "DOWNLOAD_SOURCE"
CodeBuildPhaseTypeInstall CodeBuildPhaseType = "INSTALL"
CodeBuildPhaseTypePreBuild CodeBuildPhaseType = "PRE_BUILD"
CodeBuildPhaseTypeBuild CodeBuildPhaseType = "BUILD"
CodeBuildPhaseTypePostBuild CodeBuildPhaseType = "POST_BUILD"
CodeBuildPhaseTypeUploadArtifacts CodeBuildPhaseType = "UPLOAD_ARTIFACTS"
CodeBuildPhaseTypeFinalizing CodeBuildPhaseType = "FINALIZING"
CodeBuildPhaseTypeCompleted CodeBuildPhaseType = "COMPLETED"
)

// CodeBuildEvent is documented at:
Expand Down Expand Up @@ -81,12 +81,12 @@ type CodeBuildEventDetail struct {
ProjectName string `json:"project-name"`
BuildID string `json:"build-id"`
AdditionalInformation CodeBuildEventAdditionalInformation `json:"additional-information"`
CurrentPhase CodeBuildPhaseStatus `json:"current-phase"`
CurrentPhase CodeBuildPhaseType `json:"current-phase"`
CurrentPhaseContext string `json:"current-phase-context"`
Version string `json:"version"`

CompletedPhaseStatus CodeBuildPhaseStatus `json:"completed-phase-status"`
CompletedPhase CodeBuildPhaseStatus `json:"completed-phase"`
CompletedPhase CodeBuildPhaseType `json:"completed-phase"`
CompletedPhaseContext string `json:"completed-phase-context"`
CompletedPhaseDuration DurationSeconds `json:"completed-phase-duration-seconds"`
CompletedPhaseStart CodeBuildTime `json:"completed-phase-start"`
Expand Down