Skip to content

Add Missing NewNumberSetAttribute #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Add Missing NewNumberSetAttribute #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e7a263
add NewNumberSetAttribute
daviskoh Feb 12, 2019
a9e2eea
Merge branch 'master' into master
bmoffatt Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions events/attributevalue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,14 @@ func NewNumberAttribute(value string) DynamoDBAttributeValue {
return av
}

// NewNumberSetAttribute creates an DynamoDBAttributeValue containing a NumberSet
func NewNumberSetAttribute(value []string) DynamoDBAttributeValue {
var av DynamoDBAttributeValue
av.value = value
av.dataType = DataTypeNumberSet
return av
}

// NewNullAttribute creates an DynamoDBAttributeValue containing a Null
func NewNullAttribute() DynamoDBAttributeValue {
var av DynamoDBAttributeValue
Expand Down
6 changes: 6 additions & 0 deletions events/attributevalue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,12 @@ func Test_DynamoDBAttributeValue_NewAttribute(t *testing.T) {
assert.Nil(t, err)
assert.Equal(t, float64(1.1), v)
}
{
value := []string{"2", "2.2"}
av := NewNumberSetAttribute(value)
assert.Equal(t, DataTypeNumberSet, av.DataType())
assert.Equal(t, value, av.NumberSet())
}
{
av := NewNullAttribute()
assert.Equal(t, DataTypeNull, av.DataType())
Expand Down