Skip to content

[Amazon.Lambda.RuntimeSupport] fix: Find header key with insensitive comparison #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

duncanista
Copy link

Issue

Idea for #2093

Changes

Looks up for headers without any case restrictions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boblodgett boblodgett requested a review from normj June 18, 2025 17:35
@normj normj changed the base branch from master to dev June 18, 2025 17:35
@normj normj changed the base branch from dev to master June 18, 2025 17:42
@normj
Copy link
Member

normj commented Jun 18, 2025

The change looks good but can you rebase the PR to the dev branch? The PR has picked up some commits that are in master that haven't yet been backported back to dev.

Also the PR needs a change file to take care of change log and versioning. Can you add the following content, feel free to change the change log messages, in the following file: .autover\changes\<random-guid>.json

{
  "Projects": [
    {
      "Name": "Amazon.Lambda.RuntimeSupport",
      "Type": "Patch",
      "ChangelogMessages": [
        "Fix issue making HTTP header comparisons be case insensitive"
      ]
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants