chore: Upgrade dependencies (#204)

Notes:
    in new pytest, self.assertEquals has been deprecated and self.assertEqual is recommended.
    new pylint introduces a few new rules, which has been addressed in their dedicated commits.

Author: aahung

.pylintrc

@@ -60,7 +60,8 @@ confidence=
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
 # R0205,W0107,R1705,R1710,R1719,R1720,R1714 are all disable due to a forced upgrade to support python3.8
-disable=R0201,W0613,I0021,I0020,W1618,W1619,R0902,R0903,W0231,W0611,R0913,W0703,C0330,R0204,I0011,R0904,C0301, R0205,W0107,R1705,R1710,R1719,R1720,R1714
+# R1725,W0707 can be removed when we drop Python 2 support
+disable=R0201,W0613,I0021,I0020,W1618,W1619,R0902,R0903,W0231,W0611,R0913,W0703,C0330,R0204,I0011,R0904,C0301, R0205,W0107,R1705,R1710,R1719,R1720,R1714,R1725,W0707
 
 
 [REPORTS]

aws_lambda_builders/workflows/python_pip/packager.py

@@ -550,7 +550,7 @@ def main(self, args, env_vars=None, shim=None):
 class PipRunner(object):
     """Wrapper around pip calls used by chalice."""
 
-    _LINK_IS_DIR_PATTERN = "Processing (.+?)\n" "  Link is a directory," " ignoring download_dir"
+    _LINK_IS_DIR_PATTERN = "Processing (.+?)\n  Link is a directory, ignoring download_dir"
 
     def __init__(self, python_exe, pip, osutils=None):
         if osutils is None:

requirements/dev.txt

@@ -1,19 +1,22 @@
-coverage==4.3.4
+coverage==5.3
 flake8==3.3.0; python_version < '3.8'
-flake8==3.7.9; python_version >= '3.8'
-pytest-cov==2.4.0
-# astroid > 2.0.4 is not compatible with pylint1.7
-astroid>=1.5.8,<2.1.0; python_version < '3.8'
-pylint==1.7.2; python_version < '3.8'
-pylint==2.4.4; python_version >= '3.8'
+flake8==3.8.4; python_version >= '3.8'
+pytest-cov==2.10.1
+
+# pylint 2 does not support Python 2. pylint 1.x requires astroid 1.x
+astroid~=1.6.0; python_version < '3.6'
+pylint~=1.9.5; python_version < '3.6'
+pylint~=2.6.0; python_version >= '3.6'
 isort>=4.2.5,<5; python_version < '3.8'
 
 # Test requirements
-pytest==3.0.7
-py==1.4.33
-mock==2.0.0
-parameterized==0.6.1
+pytest>=6.1.1; python_version >= '3.6'
+pytest~=4.6.11; python_version < '3.6' # pytest dropped python 2 support after 4.6.x
+mock==3.0.5; python_version < '3.6'
+mock==4.0.2; python_version >= '3.6'
+parameterized==0.7.4
 pathlib2==2.3.2; python_version<"3.4"
 futures==3.2.0; python_version<"3.2.3"
-# Py3.2 backport
-backports.tempfile==1.0
+
+# tempfile backport for < 3.6
+backports.tempfile==1.0; python_version<"3.7"

tests/functional/test_builder.py

@@ -59,4 +59,4 @@ def test_run_hello_workflow_with_exec_paths(self):
         with open(self.expected_filename, "r") as fp:
             contents = fp.read()
 
-        self.assertEquals(contents, self.expected_contents)
+        self.assertEqual(contents, self.expected_contents)

tests/functional/test_cli.py

@@ -104,14 +104,14 @@ def test_run_hello_workflow_with_backcompat(self, flavor, protocol_version):
         response = json.loads(stdout_data)
         self.assertNotIn("error", response)
         self.assertIn("result", response)
-        self.assertEquals(response["result"]["artifacts_dir"], self.artifacts_dir)
+        self.assertEqual(response["result"]["artifacts_dir"], self.artifacts_dir)
 
         self.assertTrue(os.path.exists(self.expected_filename))
         contents = ""
         with open(self.expected_filename, "r") as fp:
             contents = fp.read()
 
-        self.assertEquals(contents, self.expected_contents)
+        self.assertEqual(contents, self.expected_contents)
         shutil.rmtree(self.scratch_dir)
 
     @parameterized.expand([("request_through_stdin"), ("request_through_argument")])
@@ -160,4 +160,4 @@ def test_run_hello_workflow_incompatible(self, flavor):
         # Validate the response object. It should be error response
         response = json.loads(stdout_data)
         self.assertIn("error", response)
-        self.assertEquals(response["error"]["code"], 505)
+        self.assertEqual(response["error"]["code"], 505)

tests/functional/test_utils.py

@@ -35,10 +35,10 @@ def test_must_respect_excludes_list(self):
         excludes = [".git", ".aws-sam", "*.pyc"]
 
         copytree(self.source, self.dest, ignore=shutil.ignore_patterns(*excludes))
-        self.assertEquals(set(os.listdir(self.dest)), {"nested", "a"})
-        self.assertEquals(set(os.listdir(os.path.join(self.dest, "nested"))), set())
-        self.assertEquals(set(os.listdir(os.path.join(self.dest, "a"))), {"c"})
-        self.assertEquals(set(os.listdir(os.path.join(self.dest, "a"))), {"c"})
+        self.assertEqual(set(os.listdir(self.dest)), {"nested", "a"})
+        self.assertEqual(set(os.listdir(os.path.join(self.dest, "nested"))), set())
+        self.assertEqual(set(os.listdir(os.path.join(self.dest, "a"))), {"c"})
+        self.assertEqual(set(os.listdir(os.path.join(self.dest, "a"))), {"c"})
 
 
 def file(*args):

tests/functional/workflows/java_gradle/test_java_utils.py

@@ -33,13 +33,13 @@ def test_listdir(self):
         names = ["a", "b", "c"]
         for n in names:
             self.new_file(self.src, n)
-        self.assertEquals(set(names), set(self.os_utils.listdir(self.src)))
+        self.assertEqual(set(names), set(self.os_utils.listdir(self.src)))
 
     def test_copy(self):
         f = self.new_file(self.src, "a")
         expected = os.path.join(self.dst, "a")
         copy_ret = self.os_utils.copy(f, expected)
-        self.assertEquals(expected, copy_ret)
+        self.assertEqual(expected, copy_ret)
         self.assertTrue("a" in os.listdir(self.dst))
 
     def test_exists(self):

tests/functional/workflows/java_maven/test_java_utils.py

@@ -33,13 +33,13 @@ def test_listdir(self):
         names = ["a", "b", "c"]
         for n in names:
             self.new_file(self.src, n)
-        self.assertEquals(set(names), set(self.os_utils.listdir(self.src)))
+        self.assertEqual(set(names), set(self.os_utils.listdir(self.src)))
 
     def test_copy(self):
         f = self.new_file(self.src, "a")
         expected = os.path.join(self.dst, "a")
         copy_ret = self.os_utils.copy(f, expected)
-        self.assertEquals(expected, copy_ret)
+        self.assertEqual(expected, copy_ret)
         self.assertTrue("a" in os.listdir(self.dst))
 
     def test_exists(self):

tests/integration/workflows/custom_make/test_custom_make.py

@@ -44,7 +44,7 @@ def test_must_build_python_project_through_makefile(self):
             "chardet",
             "urllib3",
             "idna",
-            "urllib3-1.25.10.dist-info",
+            "urllib3-1.25.11.dist-info",
             "chardet-3.0.4.dist-info",
             "certifi-2020.4.5.2.dist-info",
             "certifi",
@@ -55,7 +55,7 @@ def test_must_build_python_project_through_makefile(self):
 
         expected_files = self.test_data_files.union(dependencies_installed)
         output_files = set(os.listdir(self.artifacts_dir))
-        self.assertEquals(expected_files, output_files)
+        self.assertEqual(expected_files, output_files)
 
     def test_must_build_python_project_through_makefile_unknown_target(self):
         with self.assertRaises(WorkflowFailedError):

tests/integration/workflows/dotnet_clipackage/test_dotnet.py

@@ -40,7 +40,7 @@ def test_with_defaults_file(self):
 
         output_files = set(os.listdir(self.artifacts_dir))
 
-        self.assertEquals(expected_files, output_files)
+        self.assertEqual(expected_files, output_files)
 
     def test_require_parameters(self):
         source_dir = os.path.join(self.TEST_DATA_FOLDER, "RequireParameters")
@@ -66,4 +66,4 @@ def test_require_parameters(self):
 
         output_files = set(os.listdir(self.artifacts_dir))
 
-        self.assertEquals(expected_files, output_files)
+        self.assertEqual(expected_files, output_files)