Experimental build targetting fluent-bit branches/tags #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we name this branch something specific to the features it contains, while maintaining the I don't want to occupy the general "experimental" name for project-specific code, and preferably we should also make it clear that this branch will be abandoned or deleted once we can properly test and publish images targeting upstream. Can the warning in the README also note that this branch will lose support once we are publishing more stable versions directly to ECR? |
amogh09
approved these changes
May 23, 2025
swapneils
requested changes
May 26, 2025
There was a problem hiding this comment.
Tagging the above comment (#931 (comment)) as requested changes for GitHub to notice it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for building fluent-bit versions into aws-for-fluent-bit container images beyond v1.9.10. Builds against newer versions use an environment variable
FLB_TAGto target fluent-bit branches or tags on the core repository - https://github.com/fluent/fluent-bitNo cherry-picks from https://github.com/amazon-contributing/upstream-to-fluent-bit are applied during build.
A new
/experimental/README.mdhas been added to detail the steps required to locally build and publish images to an ECR repository for use.Issue #, if available:
Testing
Some initial internal testing against integration tests has been conducted for v3.2.10 and v4.0.0 but nothing concrete/verified, so use at your own discretion.
make debugsucceeded: yesInteg tests succeeded: yes
New tests cover the changes: no
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.