Skip to content

add keyrings #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
mattsb42-aws opened this issue Apr 5, 2019 · 0 comments
Closed
10 tasks done

add keyrings #146

mattsb42-aws opened this issue Apr 5, 2019 · 0 comments

Comments

@mattsb42-aws
Copy link
Member

mattsb42-aws commented Apr 5, 2019

Starting with the AWS Encryption SDK for C, we moved from master keys/providers to keyrings as a configuration/framework primitive. We need to add corresponding keyrings to this client as well.

In order to maintain backwards compatibility, we need to retain the existing MKP framework and support the use of MKPs within the new keyring framework. After discussing several options, we decided that the best route to accomplish this is with a MKP keyring.

This MKP keyring will take a MKP as input and provide the MK/MKP management logic currently in DefaultCryptoMaterialsManager, along with necessary keyring logic (ex: adding keyring traces), all wrapped up in the new keyring interface.

As a temporary measure, in order to enable end-to-end keyring tests without tackling the MKP keyring and the updates to DefaultCryptoMaterialsManager, we will need to make a KeyringDefaultCryptoMaterialsManager that handles the signing/verification keys but only understands keyrings.

All keyring development PRs should be made to the keyring branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant