fix: eval in portableTimingSafeEqual #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eval` was added to help ensure that `portableTimingSafeEqual` is not optimized into a non-constant time function. However, the Content Security Policy `'unsafe-eval'` will flag this. It is better to remove this and risk such an optimization, then to force customers to weaken the Content Security Policy.
mattsb42-aws
requested changes
Oct 14, 2019
| * it would fail on this eval. | ||
| * The value in attempting to ensure this function is not optimized, | ||
| * is not worth the cost of making customers to alow `'unsafe-eval'`. | ||
| * If you copy this function for your own use, make sure to educate yourself. |
There was a problem hiding this comment.
Do we have a reference for such a person to read up on? Just saying "educate yourself" comes across as dismissive, and I know that was not your intent.
There was a problem hiding this comment.
This is a good point. https://codahale.com/a-lesson-in-timing-attacks/ is linked above. Perhaps adding please? I was hoping that next sentence might mitigate some of this.
There was a problem hiding this comment.
Maybe "please review the above link before use"?
Co-Authored-By: Matt Bullock <[email protected]>
Co-Authored-By: Matt Bullock <[email protected]>
Co-Authored-By: Matt Bullock <[email protected]>
Co-Authored-By: Matt Bullock <[email protected]>
Co-Authored-By: Matt Bullock <[email protected]>
mattsb42-aws
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evalwas added to help ensure thatportableTimingSafeEqualis not optimized into a non-constant time function.
However, the Content Security Policy
'unsafe-eval'will flag this.It is better to remove this and risk such an optimization,
then to force customers to weaken the Content Security Policy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: