Skip to content

chore: Improve decrypt performance for large payloads #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Comment on lines 135 to 140
let frameBuffer;
if (buffer.length > 0) {
frameBuffer = Buffer.concat([buffer, chunk]);
} else {
frameBuffer = chunk;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need whatever we come up with down at ~200-210

@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review October 17, 2024 00:25
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner October 17, 2024 00:25
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit b71e9d6 into master Oct 17, 2024
9 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the defer-buffer branch October 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants