feat(python): Add Support for Legacy DBEC and Migration Examples #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabhichow
force-pushed
the
imabhichow/legacy-extern
branch
3 times, most recently
from
1b314f4 to
21d22dd
Compare
imabhichow
commented
Jun 12, 2025
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Outdated
Show resolved
Hide resolved
imabhichow
force-pushed
the
imabhichow/legacy-extern
branch
from
21d22dd to
522b0f9
Compare
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Outdated
Show resolved
Hide resolved
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Show resolved
Hide resolved
Examples/runtimes/python/Migration/src/ddbec_to_awsdbe/awsdbe/common.py
Outdated
Show resolved
Hide resolved
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/Migration/src/ddbec_to_awsdbe/awsdbe/common.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/Migration/src/ddbec_to_awsdbe/awsdbe/migration_step_1.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/Migration/src/ddbec_to_awsdbe/awsdbe/migration_step_2.py
Outdated
Show resolved
Hide resolved
imabhichow
force-pushed
the
imabhichow/legacy-extern
branch
2 times, most recently
from
746f096 to
dbb6541
Compare
Comment on lines
+134
to
+137
| legacy_encrypted_table = LegacyEncryptedTable( | ||
| table=ddb_table, | ||
| materials_provider=cmp, | ||
| ) |
There was a problem hiding this comment.
Did you test what happens if someone provides a legacy EncryptedClient for use with the new EncryptedTable? (i.e. using clients that expect different item formats)
The InternalLegacyOverride code you wrote makes me think things are fine if this happens, but it would be great to double check.
There was a problem hiding this comment.
Chatted offline, this was tested manually and it works.
For posterity (i.e. legacy deprecation work), we will add integ tests to validate that this continues to work.
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Show resolved
Hide resolved
Examples/runtimes/python/Migration/src/ddbec_to_awsdbe/awsdbe/paginator/migration_step_1.py
Show resolved
Hide resolved
Examples/runtimes/python/Migration/test/ddbec_to_awsdbe/awsdbe/client/test_migration_step_3.py
Outdated
Show resolved
Hide resolved
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Outdated
Show resolved
Hide resolved
...ption/runtimes/python/src/aws_dbesdk_dynamodb/internaldafny/extern/InternalLegacyOverride.py
Outdated
Show resolved
Hide resolved
Comment on lines
90
to
92
| def create_encryption_config(legacy_encryptor=None, legacy_policy=None): | ||
| """Create a DynamoDbTableEncryptionConfig with optional legacy override.""" | ||
| if legacy_encryptor is not None and legacy_policy is not None: |
There was a problem hiding this comment.
Does this actually get called with the params set to None anywhere? I looked for a bit but couldn't find it, but this code is also dense (for good reason!) and I'm probably misreading.
If it's not used anymore we can probably remove it, or add cases where these params are actually None
There was a problem hiding this comment.
I'll remove the default assignment.
imabhichow
changed the title
lucasmcdonald3
approved these changes
Jun 24, 2025
imabhichow
force-pushed
the
imabhichow/legacy-extern
branch
from
c391d4a to
e43f890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
a.
EncryptedClientb.
EncryptedPaginatorc.
EncryptedResourced.
EncryptedTableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.