refactor(Go): Update examples to use utils and fix var name #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
commented
May 5, 2025
| @@ -109,15 +104,15 @@ func AwsKmsKeyringExample(kmsKeyID, ddbTableName string) { | |||
| // 4. Create the DynamoDb Encryption configuration for the table we will be writing to. | |||
| partitionKey := "partition_key" | |||
| sortKeyName := "sort_key" | |||
| algorithmSuiteId := mpltypes.DBEAlgorithmSuiteIdAlgAes256GcmHkdfSha512CommitKeyEcdsaP384SymsigHmacSha384 | |||
There was a problem hiding this comment.
fixing this to make Go idiomatic as in https://go.dev/wiki/CodeReviewComments#initialisms
…aws-database-encryption-sdk-dynamodb into Golang/Examples/refactoring
…com/aws/aws-database-encryption-sdk-dynamodb into Golang/Examples/refactoring" This reverts commit 8272eb5, reversing changes made to 78d480c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Golang/reviewedbranch so that CI will be all green even with TODOsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.