Fixes #182 Allow overriding appspec path + fallback to appspec.yml and appspec.yaml #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokite
reviewed
Sep 1, 2020
added 3 commits
September 3, 2020 20:49
Removed leftover debug typos Renamed variable to not have default in the name Added arg --appspec-path Allow for appspec-filename to be overridden
|
@yubangxi @rohkat-aws or @brblck do you guys mind re-running the travis build on the PR as I added new tests? Seems reopening/closing or new commits don't help. |
|
@vrr-21 I was wondering if you'd be able to review this one? I merged upstream changes from master so the conflicts are now resolved. |
lc-nyovchev
changed the title
|
This is a great change, testing on our end then we'll get this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #182: Allow for .yaml extension for appspec.
What is actually happening under the hood
Now we allow for a new parameter:
--appspec-filenameWhich allows us to specify (and thus override) an alternative name to the previously hardcoded
appspec.ymlfile.If the
--appspec-filenamevariable is not set, then it defaults to:appspec.yml(which is the old value)Additionally, if this parameter is set but we fail to find the file it points to in the root dir, we fallback to (in that order):
appspec.yamlappspec.ymlAcknowledgement of License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Additional notes:
@yubangxi if we are merging this, it'd be a good idea to also update the info in the doc to reflect that.