Fix for #118 (agent hangs if STDOUT/STDERR left open by hook) #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any eta on what version this will be merged to ? |
|
Can this get merged? Would really like it if my timeouts actually uhhh.... timed out. |
|
yes please, I am seeing application hooks that hang forever instead of timing out too. |
|
Is this fix / issue still being tracked? I just ran into this problem while using AWS CodeStar. |
|
@jcttrll we are currently reviewing your commit and apologies for the late reply. |
|
Hi @jcttrll, Sorry for the run-around -- could you confirm that your contribution is being made under the terms of the Apache 2.0 license? |
|
Hi, @jpeddicord, Yes, my contribution is being made under the terms of the Apache 2.0 license. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a tentative fix for Issue #118. It's tested, and relatively simple. Other enhancements, like killing the STDOUT/STDERR pump threads when their joins time out, could easily be added.
A new error code,
OUTPUTS_LEFT_OPEN_CODE = 6, is added to theScriptErrorclass. Presumably, this could be tied to information in the AWS Console for the failed event, possibly containing a link to helpful documentation?