Skip to content

standard:5.0 Golang version 1.18.1 support and bump to 1.16.15, 1.17.8 #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

friimaind
Copy link

@friimaind friimaind commented Mar 31, 2022

Closes Issues #518 and #478

Description of changes:
aws/codebuild/standard:5.0 image changes

  • Add support for golang: 1.18.1
  • Bump go 1.15 to latest version golang: 1.15.15
  • Bump go 1.16 to latest version golang: 1.16.15
  • Bump go 1.17 to latest version golang: 1.17.8

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@joekendal
Copy link

+1

@joekendal
Copy link

@clareliguori @leoherran-aws please 🙏😭

Copy link

@louie-pulse-id louie-pulse-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we all need this

@mirpo
Copy link

mirpo commented Apr 13, 2022

+1

Copy link

@mirpo mirpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joekendal
Copy link

temporary workaround for anyone stuck on this. add the following to your script:

cd $HOME/.goenv && git pull --ff-only && cd -
goenv install 1.17.0
goenv local 1.17.0

@mirpo
Copy link

mirpo commented Apr 14, 2022

@joekendal for some reason it didn't work for me: goenv: command not found
but I have working solution to share.

version: 0.2

phases:
  install:
    commands:
      ###### TEMPORARY WORKAROUND to install 1.18
      # remove after this merged https://github.com/aws/aws-codebuild-docker-images/pull/519
      - wget -q https://storage.googleapis.com/golang/go1.18.linux-amd64.tar.gz
      - tar -C /usr/local -xzf go1.18.linux-amd64.tar.gz
      - export PATH="/usr/local/go/bin:$PATH" && export GOPATH="$HOME/go" && export PATH="$GOPATH/bin:$PATH"
      - go version
      ######

result:



17 | [Container] 2022/04/14 07:03:11 Running command wget -q https://storage.googleapis.com/golang/go1.18.linux-amd64.tar.gz
18 |  
19 | [Container] 2022/04/14 07:03:13 Running command tar -C /usr/local -xzf go1.18.linux-amd64.tar.gz
20 |  
21 | [Container] 2022/04/14 07:03:16 Running command export PATH="/usr/local/go/bin:$PATH" && export GOPATH="$HOME/go" && export PATH="$GOPATH/bin:$PATH"
22 |  
23 | [Container] 2022/04/14 07:03:16 Running command go version
24 | go version go1.18 linux/amd64

@joekendal
Copy link

@joekendal for some reason it didn't work for me: goenv: command not found but I have working solution to share.

Can you confirm you have this error on aws/codebuild/standard:5.0 ?

@joekendal
Copy link

At the modern pace/schedules of software being released - calling this the AWS Standard CodeBuild Docker Images... well this is pretty bad 🙁

Exactly, this is breaking everyone's pipelines

Comment on lines 306 to 309
RUN goenv install $GOLANG_15_VERSION; rm -rf /tmp/*; \
goenv install $GOLANG_16_VERSION; rm -rf /tmp/*; \
goenv install $GOLANG_17_VERSION; rm -rf /tmp/*; \
goenv install $GOLANG_18_VERSION; rm -rf /tmp/*; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from && to ;? Are the goenv commands expected to fail?

@friimaind friimaind changed the title standard:5.0 Golang version 1.18 support and bump to 1.16.15, 1.17.8 standard:5.0 Golang version 1.18.1 support and bump to 1.16.15, 1.17.8 Apr 21, 2022
@friimaind
Copy link
Author

@lechgajewski sure! PR comment updated

Copy link

@helmus helmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see support of 1.18.1 🙏

@mirpo
Copy link

mirpo commented May 6, 2022

again stuck? 🥇

@givsly-stephen
Copy link

+1

@johannes-gehrs
Copy link

I am begging the maintainers of this repo to finally update the Go versions...

@mnugter
Copy link

mnugter commented Jun 2, 2022

Please update the allowed Go versions as bitbucket has now twice broken our code pipelines due to problems with Golang versions.

At least upgrade 1.16 to the latest version so we can use bitbucket repo's again.

@friimaind
Copy link
Author

Bitbucket just broke our pipelines again, please can we have an update for this PR?

@aws aws deleted a comment from lechgajewski Jul 1, 2022
@subinataws
Copy link
Contributor

Latest version of Go added in https://github.com/aws/aws-codebuild-docker-images/releases/tag/22.06.30

@subinataws subinataws closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.