Skip to content

Add .NET 5.0, 6.0 to Amazon Linux 2 x86-64 image #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add .NET 5.0, 6.0 to Amazon Linux 2 x86-64 image #499

wants to merge 4 commits into from

Conversation

cdonnellytx
Copy link

@cdonnellytx cdonnellytx commented Nov 16, 2021 •
edited
Loading

Issue #, if available:
N/A

Description of changes:

.NET upgrades for parity with aws/codebuild/standard:5.0 image.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

HudsonAkridge
HudsonAkridge approved these changes Dec 16, 2021
View reviewed changes
Copy link

@HudsonAkridge HudsonAkridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and something needed by our group as well

say25
say25 approved these changes Feb 7, 2022
View reviewed changes
Copy link

@say25 say25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLZ Merge

@HudsonAkridge HudsonAkridge mentioned this pull request Feb 24, 2022
Closed
@snoworc
Copy link

snoworc commented Feb 24, 2022

#497 also related

hasanmanzak
hasanmanzak approved these changes Mar 21, 2022
View reviewed changes
Copy link

@hasanmanzak hasanmanzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward enough..

@HudsonAkridge
Copy link

@leoherran-aws , could you help us understand what the next steps are to getting this merged in please?

Our group also opened up an AWS support ticket a while back to request this be merged in and was told that the AWS team that supports Codebuild was made aware of the PR and would merge it in as soon as they were able.

Could we get an ETA of that please? The delay is causing some exceptional workarounds, such as: Our team has shifted one project over to Github Actions and custom Docker Images to pull us off Codebuild completely.

Thank you!

@leoherran-aws
Copy link
Member

I cannot provide an ETA but the release process is in progress and we will update this ticket when it's complete.

@bryantqo
Copy link

bryantqo commented Apr 1, 2022 •
edited
Loading

Looking at the changes everything looks ok as far as I know. The only thing I would be concerned about is including dotnet5 as it is EOS on May 8, 2022

@snoworc
Copy link

snoworc commented Apr 12, 2022

Looking at the changes everything looks ok as far as I know. The only thing I would be concerned about is including dotnet5 as it is EOS on May 8, 2022

@bryantqo fair enough. However, this code does (did) have latest master merged in it. Whenever 5.0 support gets dropped from the current version, we can merge master again.

@cdonnellytx cdonnellytx mentioned this pull request Apr 12, 2022
Closed
@mayankbigm
Copy link

Can we please get this merged. We are waiting for .Net 6 runtime for AWS Codebuild

@mayankbigm
Copy link

mayankbigm commented May 4, 2022 •
edited
Loading

Hi @subinataws / @leoherran-aws
How are you folks!
Saw you were able to close some other PR on this repo thus reaching out
Can you or someone who has write access to this , please review and merge this.

Please feel free to tag others with write access. Much appreciated. Thanks

@benwolfpredictile
Copy link

Seriously, .Net 3.1 is EOS in a few months. Can we get some official support for .Net 6? I know I can run scripts to install this myself, but that is sort of counter to the point of the CodeBuild/CodePipeline managed services. If I wanted to build my own images I would not use CodeBuild. This is getting really late in the process. In a few months, .Net 6 will be the only supported .Net version available, yet there's no support here.

@fmendoza-pf
Copy link

fmendoza-pf commented Jun 27, 2022 •
edited
Loading

I would also add that unless I'm mistaken here, this .NET support in AWS is not open source; we're paying for it. (if this work by AWS is actually open source/free, then I apologize).

@cdonnellytx
Copy link
Author

I've resolved the conflict due to the patch version updated on master. I also updated to 5.0.408 (again, to match the other image) and to 6.0.301.

@aws aws deleted a comment from HudsonAkridge Jul 1, 2022
@subinataws
Copy link
Contributor

.net 6 is now supported in https://github.com/aws/aws-codebuild-docker-images/releases/tag/22.06.30

@subinataws subinataws closed this Jul 1, 2022
@cdonnellytx cdonnellytx deleted the feature/al2-net60 branch July 1, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HudsonAkridge HudsonAkridge HudsonAkridge approved these changes

@snoworc snoworc snoworc approved these changes

@say25 say25 say25 approved these changes

@schlossm schlossm schlossm approved these changes

@Vitaliy-Mishur Vitaliy-Mishur Vitaliy-Mishur approved these changes

@danielhertzman danielhertzman danielhertzman approved these changes

@PeterSHL PeterSHL PeterSHL approved these changes

@mayankbigm mayankbigm mayankbigm approved these changes

@hasanmanzak hasanmanzak hasanmanzak approved these changes

@mianmuneebajaz mianmuneebajaz mianmuneebajaz approved these changes

@adam-bentley adam-bentley adam-bentley approved these changes

@fmendoza-pf fmendoza-pf fmendoza-pf approved these changes

@HardBlock729 HardBlock729 HardBlock729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.