Skip to content

Add Node 16 LTS runtime #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add Node 16 LTS runtime #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f59ca46
Add Node 16 LTS runtime
jezhodges Nov 3, 2021
f48a375
Update Dockerfile
jezhodges Nov 23, 2021
272da21
Update to node 16.15.0
jezhodges May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ubuntu/standard/5.0/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,10 @@ RUN set -ex \

ENV NODE_12_VERSION="12.22.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop Node version 12 because Active Support ended 1 year and 6 months ago
(20 Oct 2020) and Security Support ended 2 weeks and 3 days ago
(30 Apr 2022).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS Lambda still supports Node.js 12 and it's not on the deprecation list. In any case: I think dropping Node 12 is out of scope for this PR.

ENV NODE_14_VERSION="14.17.2"
ENV NODE_16_VERSION="16.15.0"

RUN n $NODE_14_VERSION && npm install --save-dev -g -f grunt && npm install --save-dev -g -f grunt-cli && npm install --save-dev -g -f webpack \
RUN n $NODE_16_VERSION && npm install --save-dev -g -f grunt && npm install --save-dev -g -f grunt-cli && npm install --save-dev -g -f webpack \
&& n $NODE_14_VERSION && npm install --save-dev -g -f grunt && npm install --save-dev -g -f grunt-cli && npm install --save-dev -g -f webpack \
&& n $NODE_12_VERSION && npm install --save-dev -g -f grunt && npm install --save-dev -g -f grunt-cli && npm install --save-dev -g -f webpack \
&& curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
Expand Down Expand Up @@ -432,7 +434,7 @@ VOLUME /var/lib/docker
FROM runtimes_n_corretto AS std_v5

# Activate runtime versions specific to image version.
RUN n $NODE_14_VERSION
RUN n $NODE_16_VERSION
RUN pyenv global $PYTHON_39_VERSION
RUN phpenv global $PHP_80_VERSION
RUN rbenv global $RUBY_27_VERSION
Expand Down
4 changes: 4 additions & 0 deletions ubuntu/standard/5.0/runtimes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ runtimes:
commands:
- echo "Installing Node.js version 14 ..."
- n $NODE_14_VERSION
16:
commands:
- echo "Installing Node.js version 16 ..."
- n $NODE_16_VERSION
dotnet:
versions:
3.1:
Expand Down