chore(rds): document DatabaseInstance.fromDatabaseInstanceAttributes() (#11979)

Ensure `DatabaseInstance.fromDatabaseInstanceAttributes` is included in docs by moving it from the abstract `DatabaseInstanceBase` to the concrete `DatabaseInstance` class.

Thx @skinny85 for the suggestion in #11817.

Fixes #11817


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: ktheory

packages/@aws-cdk/aws-rds/lib/instance.ts

@@ -113,23 +113,11 @@ export interface DatabaseInstanceAttributes {
 export abstract class DatabaseInstanceBase extends Resource implements IDatabaseInstance {
   /**
    * Import an existing database instance.
+   *
+   * @deprecated use DatabaseInstance.fromDatabaseInstanceAttributes
    */
   public static fromDatabaseInstanceAttributes(scope: Construct, id: string, attrs: DatabaseInstanceAttributes): IDatabaseInstance {
-    class Import extends DatabaseInstanceBase implements IDatabaseInstance {
-      public readonly defaultPort = ec2.Port.tcp(attrs.port);
-      public readonly connections = new ec2.Connections({
-        securityGroups: attrs.securityGroups,
-        defaultPort: this.defaultPort,
-      });
-      public readonly instanceIdentifier = attrs.instanceIdentifier;
-      public readonly dbInstanceEndpointAddress = attrs.instanceEndpointAddress;
-      public readonly dbInstanceEndpointPort = attrs.port.toString();
-      public readonly instanceEndpoint = new Endpoint(attrs.instanceEndpointAddress, attrs.port);
-      public readonly engine = attrs.engine;
-      protected enableIamAuthentication = true;
-    }
-
-    return new Import(scope, id);
+    return DatabaseInstance.fromDatabaseInstanceAttributes(scope, id, attrs);
   }
 
   public abstract readonly instanceIdentifier: string;
@@ -938,6 +926,27 @@ export interface DatabaseInstanceProps extends DatabaseInstanceSourceProps {
  * @resource AWS::RDS::DBInstance
  */
 export class DatabaseInstance extends DatabaseInstanceSource implements IDatabaseInstance {
+  /**
+  * Import an existing database instance.
+  */
+  public static fromDatabaseInstanceAttributes(scope: Construct, id: string, attrs: DatabaseInstanceAttributes): IDatabaseInstance {
+    class Import extends DatabaseInstanceBase implements IDatabaseInstance {
+      public readonly defaultPort = ec2.Port.tcp(attrs.port);
+      public readonly connections = new ec2.Connections({
+        securityGroups: attrs.securityGroups,
+        defaultPort: this.defaultPort,
+      });
+      public readonly instanceIdentifier = attrs.instanceIdentifier;
+      public readonly dbInstanceEndpointAddress = attrs.instanceEndpointAddress;
+      public readonly dbInstanceEndpointPort = attrs.port.toString();
+      public readonly instanceEndpoint = new Endpoint(attrs.instanceEndpointAddress, attrs.port);
+      public readonly engine = attrs.engine;
+      protected enableIamAuthentication = true;
+    }
+
+    return new Import(scope, id);
+  }
+
   public readonly instanceIdentifier: string;
   public readonly dbInstanceEndpointAddress: string;
   public readonly dbInstanceEndpointPort: string;