This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Remove all buffer length assumptions from HTTP proofs. #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2019 08:58
Also repair CBMC proof of HTTP AddHeaders method until there is a fix to diffblue/cbmc#5096 The key insight to removing buffer length assumptions is that the code accesses all buffers via pointers in the message headers, the code does not depend on the fact that buffers follow the message headers in memory (there is no pointer arithmetic to access the start of the buffers).
dcgaws
suggested changes
Sep 20, 2019
tools/cbmc/proofs/HTTP/IotHttpsClient_ReadContentLength/Makefile.json
Outdated
Show resolved
Hide resolved
tools/cbmc/proofs/HTTP/IotHttpsClient_ReadResponseStatus/Makefile.json
Outdated
Show resolved
Hide resolved
karkhaz
approved these changes
Sep 20, 2019
dcgaws
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes buffer length assumptions from HTTP proofs.
This pull request changes a lot of files. It is easier to read one commit at a time.
The key insight to removing buffer length assumptions is that the code accesses all buffers via pointers in the message headers, the code does not depend on the fact that buffers follow the message headers in memory (there is no pointer arithmetic to access the start of the buffers).
This also repairs the CBMC proof of HTTP AddHeaders method until there is a fix to diffblue/cbmc#5096.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.