Skip to content

chore(batch): exclude deprecated code from coverage #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR excludes some deprecated classes in Batch Processing from coverage reports, and removes their unit tests since they are no longer supported and will be removed in the next major version.

As part of the PR, I also reviewed the documentation page for the feature and removed all mentions of the deprecated classes.

The only deprecated usage is the SqsFifoPartialProcessor which currently extends the BatchProcessorSync and will be switched to extend BatchProcessor (async) in the next major version.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4151


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 8, 2025
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility documentation Improvements or additions to documentation tests PRs that add or change tests labels Jul 8, 2025
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Jul 8, 2025
@dreamorosi dreamorosi requested a review from svozza July 8, 2025 21:50
@dreamorosi dreamorosi requested a review from svozza July 9, 2025 08:38
Copy link

sonarqubecloud bot commented Jul 9, 2025

@dreamorosi dreamorosi merged commit 30bbf5a into main Jul 9, 2025
46 checks passed
@dreamorosi dreamorosi deleted the chore/batch_processor_deprecated_classes branch July 9, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility documentation Improvements or additions to documentation size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: remove deprecated classes from test coverage in batch
2 participants