Skip to content

chore(ci): add il-central-1 to layer deployment pipeline #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Aug 17, 2023

Description of your changes

This PR adds il-central-1 TelAviv region to layer deployment pipeline. After the merge and the first deployment, we will increment the layer number to the latest version to align it to the same level for all regions.

Related issues, RFCs

Issue number: closes #1641

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team August 17, 2023 12:47
@boring-cyborg boring-cyborg bot added automation This item relates to automation documentation Improvements or additions to documentation labels Aug 17, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Aug 17, 2023
@am29d am29d requested review from dreamorosi and removed request for a team August 17, 2023 12:48
@am29d am29d self-assigned this Aug 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dreamorosi
Copy link
Contributor

Looks good, let's remember to align the versions once we release.

@dreamorosi dreamorosi merged commit 9668a0f into main Aug 17, 2023
@dreamorosi dreamorosi deleted the 1641-add-layer-to-il-central-1 branch August 17, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: deploy Lambda Layer in il-central-1 region
2 participants