Skip to content

chore: revisited issue & PR templates #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,31 @@ body:
attributes:
label: Code snippet
description: Please share a code snippet to help us reproduce the issue
render: JavaScript
placeholder: |
```typescript
some code here
```
validations:
required: true
- type: textarea
id: solution
attributes:
label: Possible Solution
description: If known, please suggest a potential resolution
validations:
required: false
- type: textarea
id: steps
attributes:
label: Steps to Reproduce
description: Please share how we might be able to reproduce this issue
placeholder: |
1. In this environment...
2. With this config...
3. Run '...'
4. See error...
validations:
required: true
- type: textarea
id: solution
attributes:
label: Possible Solution
description: If known, please suggest a potential resolution
validations:
required: false
- type: input
id: version
attributes:
Expand All @@ -69,7 +77,7 @@ body:
label: Packaging format used
options:
- Lambda Layers
- Npm
- npm
multiple: true
validations:
required: true
Expand Down
5 changes: 4 additions & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@ blank_issues_enabled: false
contact_links:
- name: Ask a question
url: https://github.com/awslabs/aws-lambda-powertools-typescript/discussions/new
about: Ask a general question about Lambda Powertools
about: Ask a general question about Lambda Powertools
- name: Join Community Discord Server
url: https://discord.gg/B8zZKbbyET
about: "Check out the #typescript channel"
12 changes: 8 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ body:
attributes:
value: |
Thank you for taking the time to suggest an idea to the Lambda Powertools project.

*Future readers*: Please react with 👍 and your use case to help us understand customer demand.
- type: textarea
id: problem
attributes:
Expand Down Expand Up @@ -38,11 +36,17 @@ body:
options:
- label: This feature request meets [Lambda Powertools Tenets](https://awslabs.github.io/aws-lambda-powertools-typescript/latest/#tenets)
required: true
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/)
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/), and [.NET](https://github.com/awslabs/aws-lambda-powertools-dotnet/)
required: false
- type: markdown
attributes:
value: |
---

**Disclaimer**: After creating an issue, please wait until it is triaged and confirmed by a maintainer before implementing it. This will reduce amount of rework and the chance that a pull request gets rejected.
**Disclaimer**: After creating an issue, please wait until it is triaged and confirmed by a maintainer before implementing it. This will reduce amount of rework and the chance that a pull request gets rejected.
- type: input
id: notes
attributes:
label: Future readers
description: Please not edit this field
value: "Please react with 👍 and your use case to help us understand customer demand."
12 changes: 8 additions & 4 deletions .github/ISSUE_TEMPLATE/maintenance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ body:
attributes:
value: |
Thank you for taking the time to help us improve this project.

*Future readers*: Please react with 👍 and your use case to help us understand customer demand.
- type: textarea
id: activity
attributes:
Expand Down Expand Up @@ -52,11 +50,17 @@ body:
options:
- label: This request meets [Lambda Powertools Tenets](https://awslabs.github.io/aws-lambda-powertools-typescript/latest/#tenets)
required: true
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/)
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/), and [.NET](https://github.com/awslabs/aws-lambda-powertools-dotnet/)
required: false
- type: markdown
attributes:
value: |
---

**Disclaimer**: After creating an issue, please wait until it is triaged and confirmed by a maintainer before implementing it. This will reduce amount of rework and the chance that a pull request gets rejected.
**Disclaimer**: After creating an issue, please wait until it is triaged and confirmed by a maintainer before implementing it. This will reduce amount of rework and the chance that a pull request gets rejected.
- type: input
id: notes
attributes:
label: Future readers
description: Please not edit this field
value: "Please react with 👍 and your use case to help us understand customer demand."
10 changes: 8 additions & 2 deletions .github/ISSUE_TEMPLATE/rfc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ body:
options:
- label: This feature request meets [Lambda Powertools Tenets](https://awslabs.github.io/aws-lambda-powertools-typescript/latest/#tenets)
required: true
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/)
- label: Should this be considered in other Lambda Powertools languages? i.e. [Python](https://github.com/awslabs/aws-lambda-powertools-python/), [Java](https://github.com/awslabs/aws-lambda-powertools-java/), and [.NET](https://github.com/awslabs/aws-lambda-powertools-dotnet/)
required: false
- type: markdown
attributes:
Expand All @@ -96,4 +96,10 @@ body:

* RFC PR:
* Approved by: ''
* Reviewed by: ''
* Reviewed by: ''
- type: input
id: notes
attributes:
label: Future readers
description: Please not edit this field
value: "Please react with 👍 and your use case to help us understand customer demand."
7 changes: 2 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@
<!--- If no issue is present the PR might get blocked and not be reviewed. -->
**Issue number:**

### PR status

***Is this ready for review?:*** NO
***Is it a breaking change?:*** NO

## Checklist

- [ ] [My changes meet the tenets criteria](https://awslabs.github.io/aws-lambda-powertools-typescript/#tenets)
Expand All @@ -46,6 +41,8 @@

### Breaking change checklist

***Is it a breaking change?:*** NO

- [ ] I have documented the migration process
- [ ] I have added, implemented necessary warnings (if it can live side by side)

Expand Down