Skip to content

Maintenance: make e2e test stack name unique #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flochaz opened this issue Jan 21, 2022 · 2 comments · Fixed by #788
Closed

Maintenance: make e2e test stack name unique #497

flochaz opened this issue Jan 21, 2022 · 2 comments · Fixed by #788
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing tests PRs that add or change tests

Comments

@flochaz
Copy link
Contributor

flochaz commented Jan 21, 2022

Description of the feature request

Problem statement
As of today Stack names in e2e tests are static (see https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/packages/metrics/tests/e2e/decorator.test.ts#L23 for instance) which prevent us from running multiple instances of e2e against different branches.

Summary of the feature
Add a random unique id, a branch name or a commit id to stack name in all e2e.

Code examples

const stack = new Stack(integTestApp, `MetricsE2EDecoratorStack-${process.env.GITHUB_REF_NAME ? process.env.GITHUB_REF_NAME : 'unknown'}`);

List of available env var in github action: https://docs.github.com/en/actions/learn-github-actions/environment-variables

Benefits for you and the wider AWS community
Validate PR quickly

@flochaz flochaz added the triage This item has not been triaged by a maintainer, please wait label Jan 21, 2022
@flochaz flochaz self-assigned this Jan 21, 2022
@ijemmy
Copy link
Contributor

ijemmy commented Feb 15, 2022

@flochaz I'm going to refactor metrics & tracer e2e tests to be like logger (using uuid). I can take over this if you're ok.

@dreamorosi dreamorosi assigned ijemmy and unassigned flochaz Feb 28, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Feb 28, 2022
@dreamorosi dreamorosi added enhancement and removed triage This item has not been triaged by a maintainer, please wait labels Feb 28, 2022
@saragerion saragerion added the good-first-issue Something that is suitable for those who want to start contributing label Mar 8, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added tests PRs that add or change tests completed This item is complete and has been merged/shipped automation This item relates to automation labels Nov 14, 2022
@dreamorosi dreamorosi changed the title chore(cicd): make e2e test stack name unique Maintenance: make e2e test stack name unique Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing tests PRs that add or change tests
Projects
None yet
4 participants