-
Notifications
You must be signed in to change notification settings - Fork 161
Closed
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedfeature-requestThis item refers to a feature request for an existing or new utilityThis item refers to a feature request for an existing or new utilityloggerThis item relates to the Logger UtilityThis item relates to the Logger Utility
Description
Use case
As discussed before, I would like to suggest to change the visibility of certain methods of Logger
from private
to protected
to allow overrides by subclassing Logger
. A use case for such an override would be the buffering of log messages (see #3178).
If approved, I'm happy to submit a PR.
Solution/User Experience
The following methods could be made protected
:
powertools-lambda-typescript/packages/logger/src/Logger.ts
Lines 703 to 707 in 0dc4de1
private createAndPopulateLogItem( | |
logLevel: number, | |
input: LogItemMessage, | |
extraInput: LogItemExtraInput | |
): LogItem { |
private printLog(logLevel: number, log: LogItem): void { |
powertools-lambda-typescript/packages/logger/src/Logger.ts
Lines 865 to 869 in 0dc4de1
private processLogItem( | |
logLevel: number, | |
input: LogItemMessage, | |
extraInput: LogItemExtraInput | |
): void { |
Alternative solutions
Acknowledgment
- This feature request meets Powertools for AWS Lambda (TypeScript) Tenets
- Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
Metadata
Metadata
Assignees
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedfeature-requestThis item refers to a feature request for an existing or new utilityThis item refers to a feature request for an existing or new utilityloggerThis item relates to the Logger UtilityThis item relates to the Logger Utility
Type
Projects
Status
Shipped