Skip to content

Commit 3982b4a

Browse files
authored
refactor(metrics): optimize addDimensions method to avoid O(n²) complexity (#4156)
1 parent 71d0a86 commit 3982b4a

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/metrics/src/Metrics.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,8 +764,13 @@ class Metrics extends Utility implements MetricsInterface {
764764
},
765765
...this.defaultDimensions,
766766
...this.dimensions,
767-
// biome-ignore lint/performance/noAccumulatingSpread: need to merge all dimension sets
768-
...this.dimensionSets.reduce((acc, dims) => Object.assign(acc, dims), {}),
767+
// Merge all dimension sets efficiently by mutating the accumulator
768+
...this.dimensionSets.reduce((acc, dims) => {
769+
for (const [key, value] of Object.entries(dims)) {
770+
acc[key] = value;
771+
}
772+
return acc;
773+
}, {} as Dimensions),
769774
...metricValues,
770775
...this.metadata,
771776
};

0 commit comments

Comments
 (0)