Skip to content

docs(logo): Add Capital One support for Lambda Powertools #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

djfurman
Copy link
Contributor

@djfurman djfurman commented Apr 7, 2023

Issue number: #1852

Summary

Create docs/media/logos directory and add Capital One logo.

Changes

Please provide a summary of what's being changed

  • Add recommended directory path for Lambda Powertools supporters.
  • Add Capital One logo in SVG format as a supporter.

User experience

Please share what the user experience looks like before and after this change

No UX change, logo to be included in supporters section.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

No.

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@djfurman djfurman requested a review from a team as a code owner April 7, 2023 18:28
@djfurman djfurman requested review from heitorlessa and removed request for a team April 7, 2023 18:28
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 7, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 7, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@leandrodamascena
Copy link
Contributor

Hi @djfurman! Thank you for submitting this PR and sending the Capital One logo in SVG format! We are still creating the section/site to add the customers that support the project.

Hey @rubenfonseca, do you have any considerations about merging this PR now?

@rubenfonseca
Copy link
Contributor

@leandrodamascena no considerations, please go ahead!

@leandrodamascena leandrodamascena merged commit 8818d7e into aws-powertools:develop Apr 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 13, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@leandrodamascena leandrodamascena changed the title Fix #1852 - Add Capital One support for Lambda Powertools docs(logo) - Add Capital One support for Lambda Powertools Apr 13, 2023
@leandrodamascena leandrodamascena changed the title docs(logo) - Add Capital One support for Lambda Powertools docs(logo): Add Capital One support for Lambda Powertools Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants