Skip to content

fix(ci): lambda layer workflow release version and conditionals #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 19, 2022
Merged

fix(ci): lambda layer workflow release version and conditionals #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6c1a4d2
fix(logger): preserve std keys when using custom formatters (#1264)
heitorlessa Jul 4, 2022
daf6e03
Merge branch 'develop' of https://github.com/awslabs/aws-lambda-power…
heitorlessa Jul 4, 2022
c6de9c1
fix(ci): checkout project before validating related issue workflow
heitorlessa Jul 4, 2022
0f1f1cd
chore(layers): bump to 22 for 1.26.3
heitorlessa Jul 4, 2022
89d33d3
chore(ci): limits concurrency for docs workflow
heitorlessa Jul 4, 2022
c0bb85f
fix(ci): regex to catch combination of related issues workflow
heitorlessa Jul 5, 2022
1f570a6
chore(layers): add release pipeline in GitHub Actions (#1278)
Jul 7, 2022
577a410
fix: typo in input for layer workflow
Jul 7, 2022
e0b3b58
fix: no need to cache npm since we only install cdk cli and don't hav…
Jul 7, 2022
925c145
fix: add entire ARN role instead of account and role name
Jul 7, 2022
5bcd026
fix: path to artefact
Jul 7, 2022
46c1754
fix: unzip the right artifact name
Jul 7, 2022
1170e76
docs(event-handler): snippets split, improved, and lint (#1279)
heitorlessa Jul 7, 2022
a34d34d
chore(ci): fix reference error in related_issue
heitorlessa Jul 7, 2022
ad86b10
fix: download artefact into the layer dir
Jul 7, 2022
6848d0b
Merge branch 'develop' of github.com:am29d/aws-lambda-powertools-pyth…
Jul 7, 2022
1962f19
fix: mathc the name of the cdk synth from the build phase
Jul 7, 2022
2ded8a6
fix: sight, yes a whitespace character breaks the build
Jul 7, 2022
e27029a
chore(ci): keep layer version, trigger only after success
Jul 19, 2022
b7f1cea
chore(ci): checkout depth 0 to get tags
Jul 19, 2022
825063a
merge upstream
Jul 19, 2022
50e3825
Update .github/workflows/publish_layer.yml
am29d Jul 19, 2022
7a6b342
remove dummy jobs
Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/publish_layer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ on:
types:
- completed


jobs:
build-layer:
runs-on: ubuntu-latest
if: ${{ (github.event.workflow_run.conclusion == 'success') || (github.event_name == 'workflow_dispatch') }}
defaults:
run:
working-directory: ./layer
Expand All @@ -29,8 +31,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: "16.12"
- name: Install poetry
run: pipx install poetry
- name: Setup python
uses: actions/setup-python@v4
with:
Expand All @@ -39,8 +39,8 @@ jobs:
- name: Set release notes tag
run: |
RELEASE_INPUT=${{ inputs.latest_published_version }}
GITHUB_EVENT_RELEASE_TAG=${{ github.event.release.tag_name }}
RELEASE_TAG_VERSION=${GITHUB_EVENT_RELEASE_TAG:-$RELEASE_INPUT}
LATEST_TAG=$(git describe --tag --abbrev=0)
RELEASE_TAG_VERSION=${RELEASE_INPUT:-$LATEST_TAG}
echo "RELEASE_TAG_VERSION=${RELEASE_TAG_VERSION:1}" >> $GITHUB_ENV
- name: install cdk and deps
run: |
Expand Down
46 changes: 24 additions & 22 deletions .github/workflows/reusable_deploy_layer_stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,30 @@ jobs:
strategy:
fail-fast: false
matrix:
region: ["af-south-1"]
# "eu-central-1",
# "us-east-1",
# "us-east-2",
# "us-west-1",
# "us-west-2",
# "ap-east-1",
# "ap-south-1",
# "ap-northeast-1",
# "ap-northeast-2",
# "ap-southeast-1",
# "ap-southeast-2",
# "ca-central-1",
# "eu-west-1",
# "eu-west-2",
# "eu-west-3",
# "eu-south-1",
# "eu-north-1",
# "sa-east-1",
# "ap-southeast-3",
# "ap-northeast-3",
# "me-south-1"
region: [
"af-south-1",
# "eu-central-1",
# "us-east-1",
# "us-east-2",
# "us-west-1",
# "us-west-2",
# "ap-east-1",
# "ap-south-1",
# "ap-northeast-1",
# "ap-northeast-2",
# "ap-southeast-1",
# "ap-southeast-2",
# "ca-central-1",
# "eu-west-1",
# "eu-west-2",
# "eu-west-3",
# "eu-south-1",
# "eu-north-1",
# "sa-east-1",
# "ap-southeast-3",
# "ap-northeast-3",
# "me-south-1"
]
steps:
- name: checkout
uses: actions/checkout@v3
Expand Down
3 changes: 2 additions & 1 deletion layer/layer/layer_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from aws_cdk import Stack
from aws_cdk import RemovalPolicy, Stack
from aws_cdk.aws_ssm import StringParameter
from cdk_lambda_powertools_python_layer import LambdaPowertoolsLayer
from constructs import Construct
Expand All @@ -15,5 +15,6 @@ def __init__(
)

layer.add_permission("PublicLayerAccess", account_id="*")
layer.apply_removal_policy(RemovalPolicy.RETAIN)

StringParameter(self, "VersionArn", parameter_name=ssm_paramter_layer_arn, string_value=layer.layer_version_arn)