Skip to content

docs/typing: validate method should support event as Any type #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelbrewer opened this issue Apr 17, 2021 · 1 comment
Closed

docs/typing: validate method should support event as Any type #401

michaelbrewer opened this issue Apr 17, 2021 · 1 comment
Assignees
@heitorlessa
Labels
feature-request feature request

Comments

@michaelbrewer
Copy link
Contributor

michaelbrewer commented Apr 17, 2021 •
edited
Loading

Problem

In some cases you want to use validate for something internal, like a downstream api call with returns a list of data:

Screen Shot 2021-04-17 at 2 52 47 PM

Currently validate type hints event as only a Dict, but it might be a List or Tuple etc..

Solution?

Just type event as Any
@michaelbrewer michaelbrewer added feature-request feature request triage Pending triage from maintainers labels Apr 17, 2021
@heitorlessa heitorlessa mentioned this issue Apr 19, 2021
Merged
6 tasks
@heitorlessa
Copy link
Contributor

will be merged once checks pass - one of those that MyPy/Pyright will catch once in CI. Thanks again!!!

@heitorlessa heitorlessa added pending-release Fix or implementation already in dev waiting to be released and removed triage Pending triage from maintainers labels Apr 19, 2021
@heitorlessa heitorlessa self-assigned this Apr 19, 2021
@heitorlessa heitorlessa removed the pending-release Fix or implementation already in dev waiting to be released label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heitorlessa heitorlessa

Labels
feature-request feature request
Projects
Powertools for AWS Lambda (Python)
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heitorlessa @michaelbrewer