Skip to content

fix(ci): minor fixes for workflows #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

fix(ci): minor fixes for workflows #1829

merged 4 commits into from
May 7, 2025

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented May 7, 2025

Issue #, if available: #1231

Description of changes:

  • sets JAVA_VERSION env var
  • sets head-ref for dependency-review

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sthulb sthulb requested a review from Copilot May 7, 2025 10:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces minor CI workflow fixes related to dependency review and end-to-end testing.

  • Adds the head-ref parameter in the dependency-review action.
  • Sets the JAVA_VERSION environment variable in the e2e test step.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/security-dependencies-check.yml Adds a head-ref parameter with github.ref for the dependency-review action.
.github/workflows/check-e2e.yml Updates the e2e test run command to include JAVA_VERSION from the matrix.

Copy link

sonarqubecloud bot commented May 7, 2025

@phipag phipag merged commit c2e5b92 into main May 7, 2025
15 checks passed
@phipag phipag deleted the actions-fix branch May 7, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants