Skip to content

chore(ci): Suppress Spotbugs findings #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

chore(ci): Suppress Spotbugs findings #1807

merged 1 commit into from
Mar 17, 2025

Conversation

phipag
Copy link
Contributor

@phipag phipag commented Mar 14, 2025

Issue #, if available: #1788

Description of changes:

To fix the Spotbugs workflow this PR suppresses new rules similar to what was done on the v2 branch. This should be re-visisted later to provide a proper fix.

Checklist

Breaking change checklist

None

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@phipag phipag requested a review from sthulb March 14, 2025 11:24
@phipag phipag self-assigned this Mar 14, 2025
@phipag phipag added bug Something isn't working maintenance labels Mar 14, 2025
@phipag
Copy link
Contributor Author

phipag commented Mar 14, 2025

Spotbugs checks pass locally:

mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=true
...
[INFO] Powertools for AWS Lambda (Java) library Parent 1.19.0 SUCCESS [  1.257 s]
[INFO] Powertools for AWS Lambda (Java) library Core 1.19.0 SUCCESS [  2.014 s]
[INFO] Powertools for AWS Lambda (Java) library Serialization Utilities 1.19.0 SUCCESS [  2.081 s]
[INFO] Powertools for AWS Lambda (Java) library Logging 1.19.0 SUCCESS [  3.127 s]
[INFO] Powertools for AWS Lambda (Java) library Tracing 1.19.0 SUCCESS [  1.877 s]
[INFO] Powertools for AWS Lambda (Java) library SQS 1.19.0  SUCCESS [  2.542 s]
[INFO] Powertools for AWS Lambda (Java) library Metrics 1.19.0 SUCCESS [  1.715 s]
[INFO] Powertools for AWS Lambda (Java) library Parameters 1.19.0 SUCCESS [  2.343 s]
[INFO] Powertools for AWS Lambda (Java) validation library 1.19.0 SUCCESS [  2.083 s]
[INFO] Powertools for AWS Lambda (Java) library Test Suite 1.19.0 SUCCESS [  0.238 s]
[INFO] Powertools for AWS Lambda (Java)library Cloudformation 1.19.0 SUCCESS [  1.829 s]
[INFO] Powertools for AWS Lambda (Java) library Idempotency 1.19.0 SUCCESS [  2.870 s]
[INFO] Powertools for AWS Lambda (Java) library Large messages 1.19.0 SUCCESS [  1.803 s]
[INFO] Powertools for AWS Lambda (Java)library End-to-end tests 1.19.0 SUCCESS [  1.223 s]
[INFO] Powertools for AWS Lambda (Java) batch messages 1.19.0 SUCCESS [  2.429 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Core 1.19.0 SUCCESS [  2.175 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Core 1.17.0 SUCCESS [  1.195 s]
[INFO] cdk 1.19.0 ......................................... SUCCESS [  0.175 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Core 1.19.0 SUCCESS [  1.065 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Core 1.19.0 SUCCESS [  1.381 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Idempotency 1.19.0 SUCCESS [  2.098 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Parameters 1.19.0 SUCCESS [  0.235 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Serialization 1.19.0 SUCCESS [  0.078 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - SQS 1.19.0 SUCCESS [  1.765 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Batch 1.19.0 SUCCESS [  1.753 s]
[INFO] Powertools for AWS Lambda (Java) library Examples - Validation 1.19.0 SUCCESS [  0.114 s]
[INFO] AWS Lambda Powertools for Java library Examples - CloudFormation 1.19.0 SUCCESS [  0.994 s]
[INFO] Powertools for AWS Lambda (Java) library Examples 1.19.0 SUCCESS [  0.005 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  42.876 s
[INFO] Finished at: 2025-03-14T12:15:39+01:00
[INFO] ------------------------------------------------------------------------

@phipag phipag linked an issue Mar 14, 2025 that may be closed by this pull request
@sthulb sthulb merged commit 4061087 into main Mar 17, 2025
6 checks passed
@sthulb sthulb deleted the phipag/issue1788 branch March 17, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotbug Findings
2 participants